From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, dev@rjt.dev
Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes
Date: Sat, 27 Jan 2024 16:05:20 +0800 [thread overview]
Message-ID: <875xzfkxq7.fsf@yahoo.com> (raw)
In-Reply-To: <868r4b9qjs.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jan 2024 09:35:51 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> Why was this installed on emacs-29? It is no bugfix.
>
> Bug#68708 claims that this is a bugfix.
??? That is a Coreutils bug. But I see bug#68705 in the bug tracker
now.
> Btw, Yuan: please always mention the bug number in the commit log
> messages. If you install someone else's change via "git am", and the
> author didn't mention the bug number, please use "git commit --amend"
> afterwards to add the bug number (or modify the log message in any
> other way), before you push.
Yes, please. Furthermore, if such bugfix cannot be described as
anything but a simplification (with a correspondingly large diff), there
should be another approach safer for the release branch.
Quoting Yuan's response on the bug tracker:
> Thanks Randy, pushed to emacs-29 since it includes a fix.
>
> Yuan
Our basic criterion for installing patches on emacs-29 is not whether a
change contains a bugfix, but whether it runs a risk of destablizing the
branch. It is more important that a bugfix be the only component of a
change, since that reduces the probability of unanticipated disruption.
next prev parent reply other threads:[~2024-01-27 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org>
[not found] ` <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org>
2024-01-27 4:59 ` emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Po Lu
2024-01-27 7:35 ` Eli Zaretskii
2024-01-27 8:05 ` Po Lu [this message]
2024-01-27 22:40 ` Stefan Kangas
2024-01-28 1:34 ` Po Lu
2024-01-28 3:00 ` Stefan Kangas
2024-01-28 5:21 ` Po Lu
2024-01-28 3:29 ` Dmitry Gutov
2024-01-28 5:57 ` Eli Zaretskii
2024-01-31 6:44 ` Yuan Fu
2024-01-27 8:37 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xzfkxq7.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).