From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] User-defined fringe tooltips (a request for review) Date: Wed, 27 Mar 2024 19:25:24 +0800 Message-ID: <875xx76hnf.fsf@yahoo.com> References: <83sf3xgimq.fsf@gnu.org> <83plyzfoe4.fsf@gnu.org> <83plyxca0t.fsf@gnu.org> <8334vrczig.fsf@gnu.org> <86frwejkxe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Vladimir Kazanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 27 12:26:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpRQe-0001au-4B for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Mar 2024 12:26:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpRPs-00022l-HB; Wed, 27 Mar 2024 07:26:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpRPr-00022W-EO for emacs-devel@gnu.org; Wed, 27 Mar 2024 07:25:59 -0400 Original-Received: from sonic304-21.consmr.mail.ne1.yahoo.com ([66.163.191.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpRPp-0007a7-Dg for emacs-devel@gnu.org; Wed, 27 Mar 2024 07:25:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1711538755; bh=2pcrLNcG6vWHT0nfLtvzhspCM9+GDFDBldSEb3/26JY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Zf/gQ97ouji/nVcT8nJ1dhd9sfSOJ5dYTPQfy5bND+mJ8bVnGC2+BdACaLfydNldrEBoHAs4Jdoh+hNMeJByZIf/UrjcLIBiKqlqseCYaWvBXGP22HyZUnCSydrQozz3s0eiCOIyUJhsuQI0r1+wadHonMOfiTSt5Fv/mvRGIjqPO9JbMpudxkkzS2eNsQ+Vx9+GqmODKrSvgzeutb52j5MAeBi/ptwOYQFV0GyYscqENA0Gl5kDQDfJvtsIhoQ3dRqMTKjmZA+68z12WKoMr1XYV6dx0gyYRJx9WDAGNa58a1arRN+qfy/RUgkNy2inaDcWL8KsJ+WgrOVliBi+jQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1711538755; bh=XOy/Ql96obuc9jJmzoHWkWrjqsNETuo+JoQswCC5zHX=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dnWtfgsZJpGkFtPK+qIRrnQCh1oE/h0xzdqqTDnI+Fj3i06nDgINFSDI54I5X79ahjup2NubxE8/s4GpbA3cbpWDLY2o4fdf4xA6II0oigk4fJDGAqtwxg2kCpJAS+rh3Pjz/UUUKXmt4Q1N8Q4IOgzjzC0pzENVh/RoAiOwA1VNXc69lCBD99MHKDsqQ9kNND16sxsnTShPc4RFwAcL5V8VV534ELdzAJZrJtBOY7hTn0rUyAVJOpybU5WrIpCyYVFdCRVIQrnmkpEUda7KdIk0oPj+df9auAyjoN/jb2zDrxA40hOcL4WijjE5oUPeA9wp6ACYHsqvI/jXyc+60w== X-YMail-OSG: 4UTk1s4VM1nr4IPIjjtTwNGaNKcnHdA727FXRwawXOTsG.hT8gXZiAkz.RcaYdv sYQeR8jK1lqrcx069zrpKkacZ.fLNdnES8Q0M4SZ.QmNHsPMfkWgnvCodKhoRxSbrFUmBKmhYXoj WdEi.9X0XEIP4E8YFmQNx3C4PGJYvNhQ3NFh21vcy2xFr3Ak0QwAVVP6O3V1ON4esIMlnDmGThML 0FWsWVEZth7Ib6hIAkasumrzaFIqLvnKJ0qF7YDIo8iEENreZVRCdgnileS9bmJN._mF5NaCq9pf BnwmCgDX2rOh1I2TCI1qFm.DhK5_qKm9xEI4Iu813Ka.C6Ox9GRsUKLGcdiY7zlHhablQiOwEfyq 2.la.7t8QJwaDEmymKAnmkzHY5ICYA4xPsk0h7IQfHS.Z.4e6pvSlUQQGQv1dTeuZ.5eFDl6wvgJ R.CAy4QCSpSaEPdV1AvuvSiZF9r_2aBLG9W2uf9sQhTU9EBF3jILMXj1Qf3aKu8QauX6iPaJml_X 1X_vrxjk1GlVk_xsj8hHa6OGs5kwEL6s25Aol8TcuYmZzw.4fHiYNKZSHt0vquWn45qQj42ff1L5 AMj_VY6vKj9RgZhPa74UGCpmxe50Cw50FZ09IUjjDqXi_HQggYDH55hxrgNP1B03pXsQLAzJ.kml WiLbr97ypUAyMe9UE6yuT1GrxM1SnuJovBjEfxdF99BNYZdubJ9b5MtiOBsApLklEg.UTcJeCTmY q7KUEgwrx_QJEbC2aYKgZtSZuRHJkYd15ds.M_J6RGp8Yr.84kH0gz0awORdNqkXfqv.fVGuqNYd 0UMcLnYKsxcpDgHoLiY2JuTqCTB54oxQ3ME2UP6dK7 X-Sonic-MF: X-Sonic-ID: c725bd07-6cc8-41fd-a003-0fce927bd9be Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Wed, 27 Mar 2024 11:25:55 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-r5vvk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b97818c0eed57275483c79cd9e90d19e; Wed, 27 Mar 2024 11:25:51 +0000 (UTC) In-Reply-To: (Vladimir Kazanov's message of "Wed, 27 Mar 2024 10:59:50 +0000") X-Mailer: WebService/1.1.22205 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.147; envelope-from=luangruo@yahoo.com; helo=sonic304-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317330 Archived-At: There are a number of general stylistic issues with this code, viz. the use of spaces for indentation, to columns beyond the tab width, the presence of redundant braces in if/else statements, and that of lines exceeding 80 columns. Please see that they are addressed before it is installed in Emacs, and thanks in advance.