From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: Building the igc branch on MS-Windows Date: Fri, 26 Apr 2024 10:12:58 +0200 Message-ID: <875xw4fsol.fsf@gmail.com> References: <86il063imh.fsf@gnu.org> <87ttjqghyd.fsf@gmail.com> <86zfti101u.fsf@gnu.org> <87pluegd4z.fsf@gmail.com> <86ttjp20je.fsf@gnu.org> <87y191fwnd.fsf@gmail.com> <87cyqcfv6k.fsf@gmail.com> <86o79wzi31.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14126"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd.moellmann@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 26 10:13:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0Gi9-0003ad-Is for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Apr 2024 10:13:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0Ght-0004R3-66; Fri, 26 Apr 2024 04:13:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0Ghi-0004LJ-J9 for emacs-devel@gnu.org; Fri, 26 Apr 2024 04:13:14 -0400 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0GhZ-0004BD-Nz; Fri, 26 Apr 2024 04:13:10 -0400 Original-Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5708d8beec6so2230841a12.0; Fri, 26 Apr 2024 01:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714119179; x=1714723979; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=OHT9XXlfaqzxd66L7b/Ely452Pc6B9xmLzGC1dGVYMk=; b=nOwc13lCG7FId74Fbr+dQo/+lzhOv0BThqU5sOTmJxO2rH+aP0C8wcljTMi0r5OlB6 6BcZypzqCZFCVkV2RlI/rHGPbJyMrWTEU2Wz++suESirR8l+qhDV5KmULYP5dtNDFKUb aifyewtX3iM0f1CnhTtDq6+N1+P6r5aSPr7obvrjNOyTOfVu/j8rpfVO7WbuNEhrJyEL wIFuPRm5ptdll66sddRmjW1Xv8bmDNWBmo8uAweFxGMQQPAcjwawxwfRjpZ1v45zYxfi 14zahT823gqrlXhY2j8Vod/wgf3mJMCtkYbGbKQ/fQ/3Oayovoa1LCIQhSXwn0YaKpLn 4cig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714119179; x=1714723979; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OHT9XXlfaqzxd66L7b/Ely452Pc6B9xmLzGC1dGVYMk=; b=dMR0vvpDjZgqU60/Kkiwhjzi4Bq7iUku92/OSyOEzKrQbO434CHrt5yDDjGAHLb4Yf AFNQvrTtsWIRUdD/hWCZ7ZxaGTL//lkIoUyrdbMIJemCpm8Rkk2OuF84N8uHj3h/3/hs Rs1Wd3tnfTluzy1uiOC/lt0DqPqgQ9Pz2opvZh58O5rKdwRzg+fAROuis/sX4ehHaxIP IyeGSDHskrvYayoLUWJqUkCheEvyI5URSnYPQ46aMZsXiUtkTF46uYHUpSaehcXHBLWM Uz6HqwT0KqPnEMmZaXtoJcahywC2AsJTu3j1+XI6v8i5ntq9wBwVVp9pkKCZoVE13UG8 CxRg== X-Forwarded-Encrypted: i=1; AJvYcCVWY1OpoBZofelde0uCkbXUwq2sE8RFKzvZB7vmicdQ6wdV94+VWSAfibc8C3fYIsRVNB0L1CCURSRllGFE5bALtXdB X-Gm-Message-State: AOJu0Yx+91U/tibMAfwuAcJmfxj9e3Qo1isDHjFREbTD9wrDgkBviYK+ arGPBHmuWK4kXNJk5THjtmlyCO5y5fWF/kHaA73/xS8iIGmxluz58Gf3Nw== X-Google-Smtp-Source: AGHT+IHJOmaqZEibWKlTc4Fxfe9b/K2cKqesD7bTDeuFtR2vtN0sXgKTY4oRn+W2JUh8SMukWUOo0A== X-Received: by 2002:a50:d792:0:b0:56e:23e3:bdc2 with SMTP id w18-20020a50d792000000b0056e23e3bdc2mr2017136edi.13.1714119178961; Fri, 26 Apr 2024 01:12:58 -0700 (PDT) Original-Received: from caladan ([89.107.106.118]) by smtp.gmail.com with ESMTPSA id el5-20020a056402360500b005725e1100b9sm56425edb.54.2024.04.26.01.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 01:12:58 -0700 (PDT) In-Reply-To: <86o79wzi31.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Apr 2024 10:41:38 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=eller.helmut@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318112 Archived-At: > installed this in your name, with one difference: > >> + if (FRAME_WINDOW_P (f) && FRAME_OUTPUT_DATA (f)) >> + { >> + struct font *font = FRAME_FONT (f); >> + if (font) >> + IGC_FIX12_RAW(ss, &FRAME_FONT (f)); > > You already used FRAME_FONT, so not necessary to use it again: > > if (FRAME_WINDOW_P (f) && FRAME_OUTPUT_DATA (f)) > { > struct font *font = FRAME_FONT (f); > if (font) > IGC_FIX12_RAW(ss, &font); <<<<<<<<<<<<<<<<<<<<< > } I think this change introduced a bug. Remember that MPS is moving GC. So it sometimes needs to update the pointer in the struct that we are scanning. We have to give it the address of the field, not the address of some local variable on the stack. Perhaps clearer is this: struct font **font = &FRAME_FONT (f); if (*font) IGC_FIX12_RAW(ss, font); > However, the crashes while scrolling through xdisp.c are still there. > I just had 2 of them; backtraces below. It sounds like the first one > is due to Lisp strings, but the second one is related to markers. > > igc.c:1584: Emacs fatal error: assertion failed: !"other" Yes, I see this too. I will try to write some code to reproduce this without needing manual input. Helmut