Re: MPS image cache

[Helmut Eller <eller.helmut@gmail.com>]

On Fri, May 03 2024, Gerd Möllmann wrote:

> I think I have one: struct terminal's image_cache is not traced. AFAICS,
> the cache is malloc'd and contains struct image which is an MPS object.
>
> WDYT?

Two options come to mind:
  1) trace it in fix_terminal
  2) register terminal.c:terminal_list as root.

It seems to me that creating a root is more "correct".

I have a similar problem with xterm.c:x_display_list which could be
registered as root or traced e.g. fix_frame.  (Also note that struct
struct terminal contains a x_display_info, which is probably the same as
the in x_display_list.)

So maybe we should indeed register terminal_list and as part of the
scan function, also trace the display_info.

There is a bit of an issue with proper initialization of the structs
pointed to by those roots.  E.g. x_term_init uses xzalloc, puts pointers
into the struct, and only then stores the pointer to the struct in
x_display_list.  So what should be the root, the struct (registred
immediately after the call to xzalloc) or the global variable
x_display_list?