From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Dired delete(d) the wrong file! Date: Fri, 05 Jul 2024 09:11:51 +0200 Message-ID: <875xtknwi0.fsf@web.de> References: <86r0c875s4.fsf@gnu.org> <875xtk4cb3.fsf@yahoo.com> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9543"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:wGHtUKEDaKL/QxWcpTIbeOZEmow= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 05 09:12:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPd6t-0002He-AB for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jul 2024 09:11:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPd67-0005qL-K9; Fri, 05 Jul 2024 03:11:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPd65-0005pv-CB for emacs-devel@gnu.org; Fri, 05 Jul 2024 03:11:09 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPd63-00066n-3O for emacs-devel@gnu.org; Fri, 05 Jul 2024 03:11:09 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sPd60-00015u-1V for emacs-devel@gnu.org; Fri, 05 Jul 2024 09:11:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321379 Archived-At: Po Lu writes: > Yes, that was my point. Something on Dave's system is otherwise than it > is on the system where Dired was reported to identify the correct file. Edebugging `insert-directory-clean' reveals that here: #+begin_src emacs-lisp (while (< (point) end) (let ((start (insert-directory-adj-pos (+ beg (read (current-buffer))) error-lines)) (end (insert-directory-adj-pos (+ beg (read (current-buffer))) error-lines))) (if (memq (char-after end) '(?\n ?\s)) ;; End is followed by \n or by " -> ". (put-text-property start end 'dired-filename t) ;; It seems that we can't trust ls's output as to ;; byte positions of filenames. (put-text-property beg (point) 'dired-filename nil) (end-of-line)))) #+end_src the loop gets aborted because the (memq (char-after end) '(?\n ?\s)) call, when using Dave's ls options, returns the slash character that comes after ".": | bash-5.2:micha:tmp$ ls -alF --dired | total 72 | drwxr-xr-x 3 micha micha 4096 Jul 5 07:26 ./ | drwxr-xr-x 213 micha micha 61440 Jul 5 07:07 ../ | -rw-rw-r-- 1 micha micha 0 Jul 5 07:25 '07 nov 2395 zz.kk' | drwxr-xr-x 3 micha micha 4096 Jun 23 2014 src/ | //DIRED// 60 61 112 114 164 183 233 236 | //DIRED-OPTIONS// --quoting-style=shell-escape and so we throw away that information. 60 and 61 are the positions before and after the "." directory. Michael.