From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 7a8ca202c5e: Fix flakey proced refine tests (Bug#73441) Date: Wed, 20 Nov 2024 15:46:07 +0100 Message-ID: <875xoix8sw.fsf@gmail.com> References: <173004423280.3739494.8982201561873340907@vcs3.savannah.gnu.org> <20241027155033.2985235EE9B@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35809"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Laurence Warne To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 20 15:47:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDlzB-00097y-73 for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Nov 2024 15:47:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDlyB-0002LF-Hb; Wed, 20 Nov 2024 09:46:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDly9-0002KD-Ej for emacs-devel@gnu.org; Wed, 20 Nov 2024 09:46:13 -0500 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDly8-0006uw-1t for emacs-devel@gnu.org; Wed, 20 Nov 2024 09:46:13 -0500 Original-Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-43161e7bb25so57465855e9.2 for ; Wed, 20 Nov 2024 06:46:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732113969; x=1732718769; darn=gnu.org; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dhf4Y+c7LtRQ0waamXWcUpct96N/Tb9EndNKo3jJ+7U=; b=BGEK6UH/FLwwnM9VGj4uBHOqqWqbXMwwf7cnR8/M2bvEzY/epD4wvhXmpOsYz2nmis 5uUmK8G4u9iWriV0sFWw5HjRIrUl7fHXb9w6h+C/r5+/V4ineeEtt4Pt/1IY0xEasxct wFY25PcUGenmPA6FLcBlcYPzH3TojaIGzseu14aHFCDKXH02JLjA8cnpkJLFtBaQswg3 Y/c5LqwmMBf/c50ESxjnFZCPkRUlw19jaxFxs0TePp6TY86enDT229m8YbwcNk75x+Wi VBT0mcyjT3QaJmkz1PfoQesiIDspr1u3x2Jc881mmODfksX77cp+fWabzWs8y6aDfmp3 Aakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732113969; x=1732718769; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dhf4Y+c7LtRQ0waamXWcUpct96N/Tb9EndNKo3jJ+7U=; b=dd++5r2SBLaZsp/p7ObjVXtOt9vHgL0T7clpJZEIhgYUXrhKSB+Sr6v7IS3bFNGQ4/ KmBQvQetw/e1h8fWfY/dCle0/W0L07ejKzFcoR1YFQ0KPL5LEju3I035xxmau61Q/Bxw iIIkBQ/oABHnmvAOT/dCkEpqg6oOpcKa1kxhdTDJyVK3+3SjCSLhokW2lLjp/NTP/rew fl9UHIA3jOqtKbPho/dQ8fm7euitvzDaOQNbGx0mxPaza4ajjBLE7NlmqKngMaPtVdEJ RiMeyglSNfxapIG5vPEQ31ufTTm5cYWPsjH9hjE2WI00UL9pNumX181ROt33UmM7k0IE wTMA== X-Gm-Message-State: AOJu0YyaEA/RYCtsf/WR3z467x0hTWl5HWXgexmGankpLK9me+jj+aAw PPUo42iJV9TTmbNxPtRlsD2/siaRndI39Ke0LjZpBOuDg6zbC32TbSNphQ== X-Google-Smtp-Source: AGHT+IGK8n570j7pAiul5I3yR1R82pqwFlU6f5HAMhvTA4O8H2ek07xpgbxndgp/yhh9zAn1XQ/ZEg== X-Received: by 2002:a05:600c:a186:b0:432:c774:2e2b with SMTP id 5b1f17b1804b1-4334f02191cmr23833465e9.32.1732113969356; Wed, 20 Nov 2024 06:46:09 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb51:6bef:3f8d:7f49:ef6b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b01e103bsm22404615e9.9.2024.11.20.06.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 06:46:08 -0800 (PST) In-Reply-To: <20241027155033.2985235EE9B@vcs3.savannah.gnu.org> (Michael Albinus via Mailing list for Emacs changes's message of "Sun, 27 Oct 2024 11:50:32 -0400 (EDT)") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325519 Archived-At: >>>>> On Sun, 27 Oct 2024 11:50:32 -0400 (EDT), Michael Albinus via Mailing list for Emacs changes said: Michael> branch: emacs-30 Michael> commit 7a8ca202c5eeb810e5f86510c3ea46d3ec519222 Michael> Author: Laurence Warne Michael> Commit: Michael Albinus Michael> Fix flakey proced refine tests (Bug#73441) Michael> * test/lisp/proced-tests.el (proced-refine-test) Michael> (proced-refine-with-update-test): Use the much simpler CPU refinement Michael> for testing 'proced-refine'. The previous tests made the incorrect Michael> assumption that refining on the PID of process A only filtered the Michael> buffer to contain process A and its children, whereas in actuality Michael> the children of process A's children, their children, and so on will Michael> also be shown. Michael> (proced-update-preserves-pid-at-point-test): Mark as unstable. This causes proced-refine-test and proced-refine-with-update test failures on macOS, where %CPU is not implemented [1]. Probably we should stick a check for darwin around them in emacs-30. Robert Footnotes: [1] Probably because it appears to be non-trivial. --