unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Laurence Warne <laurencewarne@gmail.com>
Subject: Re: emacs-30 7a8ca202c5e: Fix flakey proced refine tests (Bug#73441)
Date: Wed, 20 Nov 2024 15:46:07 +0100	[thread overview]
Message-ID: <875xoix8sw.fsf@gmail.com> (raw)
In-Reply-To: <20241027155033.2985235EE9B@vcs3.savannah.gnu.org> (Michael Albinus via Mailing list for Emacs changes's message of "Sun, 27 Oct 2024 11:50:32 -0400 (EDT)")

>>>>> On Sun, 27 Oct 2024 11:50:32 -0400 (EDT), Michael Albinus via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

    Michael> branch: emacs-30
    Michael> commit 7a8ca202c5eeb810e5f86510c3ea46d3ec519222
    Michael> Author: Laurence Warne <laurencewarne@gmail.com>
    Michael> Commit: Michael Albinus <michael.albinus@gmx.de>

    Michael>     Fix flakey proced refine tests (Bug#73441)
    
    Michael>     * test/lisp/proced-tests.el (proced-refine-test)
    Michael>     (proced-refine-with-update-test): Use the much simpler CPU refinement
    Michael>     for testing 'proced-refine'.  The previous tests made the incorrect
    Michael>     assumption that refining on the PID of process A only filtered the
    Michael>     buffer to contain process A and its children, whereas in actuality
    Michael>     the children of process A's children, their children, and so on will
    Michael>     also be shown.
    Michael>     (proced-update-preserves-pid-at-point-test): Mark as unstable.

This causes proced-refine-test and proced-refine-with-update test
failures on macOS, where %CPU is not implemented [1]. Probably we should
stick a check for darwin around them in emacs-30.

Robert

Footnotes:
[1]  Probably because it appears to be non-trivial.

-- 



           reply	other threads:[~2024-11-20 14:46 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20241027155033.2985235EE9B@vcs3.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xoix8sw.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=laurencewarne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).