From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Arsen_Arsenovi=C4=87?= Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Thu, 02 Jan 2025 22:19:47 +0100 Message-ID: <875xmwykuk.fsf@aarsen.me> References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <86wmfdhwg7.fsf@gnu.org> <0347118b217c57e4e62018547883fad5f1d1e63e.camel@yandex.ru> <86r05lht77.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35036"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Konstantin Kharlamov , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 02 22:20:59 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTScl-0008tJ-H4 for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jan 2025 22:20:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTSc9-0007tt-Ke; Thu, 02 Jan 2025 16:20:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTSc3-0007bb-Vp for emacs-devel@gnu.org; Thu, 02 Jan 2025 16:20:16 -0500 Original-Received: from mout-p-103.mailbox.org ([80.241.56.161]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1tTSbu-0001Uc-6R; Thu, 02 Jan 2025 16:20:09 -0500 Original-Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4YPKNQ1Dpyz9sW4; Thu, 2 Jan 2025 22:19:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1735852790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n9rkePxpJn8iSQW0hlpRqBgPdSSly4//FpYcqEYnn50=; b=aC5wSJp5OQsNf+jkPHzflMQchHCVMrMSqsE+QVc5L05grtvCgj2xeBik6LQnQhJNf24U2j dlO81Mp9R8iLZUUwQKGN5iFPxHr7ZF/9oC/R1Un1tLo0Gc8ah0CAqjqVDQE6THLUdFU4da 0EGxJgbvGnh410yIbB2EcAOvwn9/FfS+prwRcP3i6cz3vbavlnM6ToPpya0Z2fGPFD67uV 6OkJPTO+1IAsIqCCO2yX33BXmFfsOeTMNvhrLvuNgLY7lIlsONQS0s19bNIe5PmVHC5Ut1 FIvVnCCUYm81kg5lMTNDr2xEwYoY4YYztkafUyOQocTlUhrGzVgj/+c3SbpcXg== In-Reply-To: <86r05lht77.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Jan 2025 22:11:24 +0200") Received-SPF: pass client-ip=80.241.56.161; envelope-from=arsen@aarsen.me; helo=mout-p-103.mailbox.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327598 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Konstantin Kharlamov >> Cc: emacs-devel@gnu.org >> Date: Thu, 02 Jan 2025 22:07:46 +0300 >>=20 >> On Thu, 2025-01-02 at 21:01 +0200, Eli Zaretskii wrote: >> > Do you plan to make this mode be descendant of change-log-mode? >> > something else? >>=20 >> I thought of deriving from text-mode. I don't know much of change-log- >> mode besides what it says in the mode title and now that I'm looking at >> mode description it also sounds pretty vague. So=E2=80=A6 I could derive= it >> from change-log-mode if you think it's useful, but I'd rely on your >> judgment here =F0=9F=98=8A > > change-log-mode is also a derivative of text-mode. Its advantage is > that it already provides font-lock for the style of log entries we > use. A thing that a git commit mode ought to do, however, is set fill-column to 72, highlight any content on line 2 as erroneous, and limit the first line to 50 characters. This is conventional in Git: https://git-scm.com/docs/git-commit#_discussion https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project.ht= ml#_commit_guidelines Naturally, all of this ought to be configurable, but these are important features and sane defaults, and are one of the primary reasons why I initially installed magit (though, I now use it for general Git interaction while editing). As far as I know, some of these guidelines conflict with changelog guidelines. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZ3cC8xAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosST1pAA/1e7F63aR2eyt46f/B3J2KsssgTrEcPrb0yw NpzP8MzuAP48qxyjAeQH5wPpMDfyPGaKowVDNXUl0yw2dD4eQWdGAA== =mvoQ -----END PGP SIGNATURE----- --=-=-=--