From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Wed, 08 Jan 2025 06:02:00 +0000 Message-ID: <875xmpzvvr.fsf@posteo.net> References: <87ldx0vufd.fsf@sebasmonia.com> <8fde5a67-f778-f0c8-bcdd-ece08c95d369@gmail.com> <87h67nm4su.fsf@sebasmonia.com> <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> <36a57a48-76ab-4254-b3bc-af1fff2d9b98@app.fastmail.com> <87ttb9k04u.fsf@sebasmonia.com> <86wmfkt6ei.fsf@gnu.org> <39071ad9-a369-2e2f-aa1c-779f8103b566@gmail.com> <87cyh8z9tg.fsf@sebasmonia.com> <87seq1alkl.fsf@sebasmonia.com> <36ff480e-0155-479d-87fb-9a85232dac47@app.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38962"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Sebasti=C3=A1n_Mon=C3=ADa?= , Adam Porter , Jim Porter , Eli Zaretskii , emacs-devel To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 08 06:56:45 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVP3c-0009yq-Rx for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Jan 2025 06:56:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVP2o-0005tq-Td; Wed, 08 Jan 2025 00:55:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVP2m-0005tU-KG for emacs-devel@gnu.org; Wed, 08 Jan 2025 00:55:52 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVP2k-0001tj-LK for emacs-devel@gnu.org; Wed, 08 Jan 2025 00:55:52 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DE5AC240101 for ; Wed, 8 Jan 2025 06:55:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1736315745; bh=MnIg0HGn62W7v9YzfN/b6HBefjC1uqu6tj67NhAh/KA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=r0wlKnyE1rsT5w7PvAphRq8tmuouQLEY+TSSyNzio8dSRbx58EvBKw/jeHqsj3wzV /hfDDw+at9zgO2k5z9OZzuc4HOmZrVGP/mDk8m3UgESOozpWpDhPKPbixdNqDyLups QMjpMP/m0WcVXz0WmK42jv/H/P8cDLD+sqFAtfrT2wtJQ+e8Jj2bROTdN2y6XXeqDU BMXAz2D5El+L/ZZAZ93AKeQRsCYwPXtTpriicxbWQZl+3flK77cTkvDsiGyTlg5jKx iBKr3cAV0x+Si/zTx2elFimUnl+9mw3VfxcK0uoCjb8t0OXjb4h99nO6BkGGWgNb+O MDCMeD9ost5bA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YScbL4TkDz9rxG; Wed, 8 Jan 2025 06:55:42 +0100 (CET) In-Reply-To: (Stefan Kangas's message of "Tue, 7 Jan 2025 21:01:52 +0000") Received-SPF: pass client-ip=185.67.36.66; envelope-from=thievol@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327779 Archived-At: Stefan Kangas writes: > Sebasti=C3=A1n Mon=C3=ADa writes: > >> Stefan Kangas writes: >>> Sebasti=C3=A1n Mon=C3=ADa writes: >>> >>>> lack of movement in this thread which is probably a >>>> gauge for interest in the change. >>> >>> I wouldn't necessarily interpret a lack of replies or a long >>> turnaround time as disinterest[...] keep in mind that all of us are >>> volunteers, and do this in our free time too. >> >> Yes, this is why I said "probably". Heck, even when I made updates to the >> patch, sometimes I took a long time to get to it :) >> >> But since Eli's latest ping and the subsequent conversation about >> deprecating EWW's own bookmark mechanism, I am thinking that maybe this >> isn't worth our collective time. Again, coming from a practical place! > > Is there any reason not to merge your latest patch while we wait for > deprecating EWW's bookmarks to happen? Adam says that it's already an > improvement, and I'd agree if it means replacing bespoke code with using > vtable. From a cursory look, I don't see anything controversial in > there. > > Adam also asked for people to speak up if they object to the patch over > a week ago, and no one did. If you plan to move to emacs bookmarks, I see no reasons to use vtable, it will complicate conversion of eww bookmarks to bookmarks which is actually trivial.=20 --=20 Thierry