unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Sašo Živanović" <saso.zivanovic@guest.arnes.si>
To: Tassilo Horn <tsdh@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix RefTeX to show table of contents for dtx files
Date: Mon, 2 Jan 2017 16:41:24 +0100	[thread overview]
Message-ID: <8755209c-85cf-570f-525b-69486a0fffaf@guest.arnes.si> (raw)
In-Reply-To: <87k2adzm5a.fsf@gnu.org>

Hi Tassilo!

Thanks for the prompt reply and commit!

On 02. 01. 2017 13:22, Tassilo Horn wrote:
> Sašo Živanović <saso.zivanovic@guest.arnes.si> writes:
>
> Hi Sašo,
>
>> I've fixed a tiny bug in RefTeX: TOC was not shown for dtx files.
>
> Good catch, thanks!
>
> I've committed your patch with a slight modification.  Instead of this
>
>> -                 (when toc-entry
>> +                 (when (and toc-entry
>> +                            (equal
>> +                             (equal (char-after bound) ?%)
>> +                             (string-suffix-p ".dtx" file)
>> +                             ))
>
> I used
>
>                    (when (and toc-entry
>                             (eq ;; Either both are t or both are nil.
>                              (= (char-after bound) ?%)
>                              (string-suffix-p ".dtx" file)))
>
> which looks a bit more clear to me.
Fine with me. You see that my lisp is pretty rudimentary ...

>
> I've seen that this is your first patch to Emacs, and given that it's
> less than 15 lines of code, I can commit it for you as-is.  However, if
> you plan to contribute more in the future, a copyright assignment will
> be due.
Gladly.

Best,
Sašo

>
> Bye,
> Tassilo
>




      reply	other threads:[~2017-01-02 15:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 10:49 [PATCH] Fix RefTeX to show table of contents for dtx files Sašo Živanović
2017-01-02 12:22 ` Tassilo Horn
2017-01-02 15:41   ` Sašo Živanović [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8755209c-85cf-570f-525b-69486a0fffaf@guest.arnes.si \
    --to=saso.zivanovic@guest.arnes.si \
    --cc=emacs-devel@gnu.org \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).