From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: ChangeLog fontifications Date: Tue, 11 May 2004 21:03:03 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <874qqmdep6.fsf@mail.jurta.org> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1084299761 25933 80.91.224.253 (11 May 2004 18:22:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 May 2004 18:22:41 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 11 20:22:29 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNbtc-0005cD-00 for ; Tue, 11 May 2004 20:22:28 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNbtY-000248-00 for ; Tue, 11 May 2004 20:22:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNbtJ-0005h0-16 for emacs-devel@quimby.gnus.org; Tue, 11 May 2004 14:22:09 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BNbt0-0005Vm-Sb for emacs-devel@gnu.org; Tue, 11 May 2004 14:21:50 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BNbrM-0004Vw-8S for emacs-devel@gnu.org; Tue, 11 May 2004 14:20:43 -0400 Original-Received: from [66.33.219.19] (helo=spoon.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNbnP-0003XB-F9 for emacs-devel@gnu.org; Tue, 11 May 2004 14:16:03 -0400 Original-Received: from mail.jurta.org (80-235-44-143-dsl.mus.estpak.ee [80.235.44.143]) by spoon.dreamhost.com (Postfix) with ESMTP id C1E6013D816 for ; Tue, 11 May 2004 11:16:01 -0700 (PDT) Original-To: emacs-devel@gnu.org In-Reply-To: (Sam Steingold's message of "Tue, 11 May 2004 13:15:52 -0400") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23166 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23166 Sam Steingold writes: > when ChangeLog records a change in a Common Lisp function with a > package prefix, only the package name is highlighted, not the function > name: > > * foo.lisp (PACK:FUNCTION-NAME): optimized frobnifications > > "PACK" is highlighted but "FUNCTION-NAME" is not. > > I am pretty sure that `change-log-font-lock-keywords' in add-log.el > needs to be fixed, but I am not quite sure how... I see no harm in removing : from regexps of function names. I don't understand why such restriction was added here, given the fact that parentheses around a function name already pretty safely enclose it. Index: lisp/add-log.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v retrieving revision 1.149 diff -u -r1.149 add-log.el --- lisp/add-log.el 19 Apr 2004 11:31:05 -0000 1.149 +++ lisp/add-log.el 11 May 2004 17:57:14 -0000 @@ -230,13 +230,13 @@ ;; Possibly further names in a list: ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face)) ;; Possibly a parenthesized list of names: - ("\\= (\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face)) - ("\\=, *\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face))) + ("\\= (\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face)) + ("\\=, *\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face))) ;; ;; Function or variable names. - ("^\t(\\([^) ,:\n]+\\)" + ("^\t(\\([^) ,\n]+\\)" (1 'change-log-list-face) - ("\\=, *\\([^) ,:\n]+\\)" nil nil (1 'change-log-list-face))) + ("\\=, *\\([^) ,\n]+\\)" nil nil (1 'change-log-list-face))) ;; ;; Conditionals. ("\\[!?\\([^]\n]+\\)\\]\\(:\\| (\\)" (1 'change-log-conditionals-face)) -- Juri Linkov http://www.jurta.org/emacs/