unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* gnus/html2text.el
@ 2004-10-25  2:46 Luc Teirlinck
  2004-10-25 17:18 ` gnus/html2text.el Reiner Steib
  2004-10-26  9:04 ` gnus/html2text.el Richard Stallman
  0 siblings, 2 replies; 14+ messages in thread
From: Luc Teirlinck @ 2004-10-25  2:46 UTC (permalink / raw)


gnus/html2text.el calls `beginning-of-buffer', disguised as
`html2text-buffer-head' at several places _inside a loop_.
`beginning-of-buffer' should usually not be called from Lisp to begin
with, unless one really _wants_ to set the mark, but calling it
inside a loop completely ruins the mark ring (and probably slows
things down a lot too).  It should use (goto-char (point-min)), as
clearly explained in the beginning-of-buffer docstring.

Unfortunately, after grepping around a little bit, it would at first
view seem that such abuse of {beginning,end}-of-buffer and other mark
setting commands is even substantially more widespread than the kind
of abuses of `interactive-p' we have been looking at.  Whether
something is an abuse or not is not always obvious, because
occasionally one _really_ wants to set the mark from Lisp.
In the case of gnus/html2text.el it _is_ obvious, however.

Sincerely,

Luc.

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2004-10-27 17:35 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-25  2:46 gnus/html2text.el Luc Teirlinck
2004-10-25 17:18 ` gnus/html2text.el Reiner Steib
2004-10-26  9:04 ` gnus/html2text.el Richard Stallman
2004-10-26 16:43   ` gnus/html2text.el Stefan Monnier
2004-10-26 22:31     ` gnus/html2text.el Kim F. Storm
2004-10-27  1:35       ` gnus/html2text.el Stefan Monnier
2004-10-27  1:43         ` gnus/html2text.el Luc Teirlinck
2004-10-27  3:08           ` gnus/html2text.el Stefan Monnier
2004-10-27  3:24             ` gnus/html2text.el Luc Teirlinck
2004-10-27  3:32               ` gnus/html2text.el Luc Teirlinck
2004-10-27  1:45         ` gnus/html2text.el Miles Bader
2004-10-27 17:35         ` gnus/html2text.el Richard Stallman
2004-10-27  2:43   ` gnus/html2text.el Luc Teirlinck
2004-10-27  3:02   ` gnus/html2text.el Luc Teirlinck

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).