From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: obsolete comment in tool-bar.el Date: Tue, 19 Jul 2005 10:41:42 -0400 Message-ID: <874qaqg8w0.fsf-monnier+emacs@gnu.org> References: <200507071915.j67JFZT29961@raven.dms.auburn.edu> <200507090235.j692ZER04883@raven.dms.auburn.edu> <200507110321.j6B3LgG09526@raven.dms.auburn.edu> <85y88dfcqw.fsf@lola.goethe.zz> <200507130302.j6D32qE05640@raven.dms.auburn.edu> <200507140208.j6E28tr08794@raven.dms.auburn.edu> <200507141830.j6EIU5r11167@raven.dms.auburn.edu> <878y08k857.fsf-monnier+emacs@gnu.org> <200507151353.j6FDrMf12755@raven.dms.auburn.edu> <200507160204.j6G24XE13583@raven.dms.auburn.edu> <200507190259.j6J2xmf16875@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1121785064 17571 80.91.229.2 (19 Jul 2005 14:57:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2005 14:57:44 +0000 (UTC) Cc: rms@gnu.org, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 19 16:57:36 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DutWq-0005RH-Oq for ged-emacs-devel@m.gmane.org; Tue, 19 Jul 2005 16:57:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DutYo-0000wy-Kq for ged-emacs-devel@m.gmane.org; Tue, 19 Jul 2005 10:59:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DutY9-0000ao-3i for emacs-devel@gnu.org; Tue, 19 Jul 2005 10:58:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DutTl-0007d5-6l for emacs-devel@gnu.org; Tue, 19 Jul 2005 10:54:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DutTe-0007Yd-4y for emacs-devel@gnu.org; Tue, 19 Jul 2005 10:53:46 -0400 Original-Received: from [209.226.175.74] (helo=tomts20-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DutRB-0005iN-14; Tue, 19 Jul 2005 10:51:13 -0400 Original-Received: from alfajor ([67.68.217.253]) by tomts20-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050719144142.IYZQ19894.tomts20-srv.bellnexxia.net@alfajor>; Tue, 19 Jul 2005 10:41:42 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id 5019ED7571; Tue, 19 Jul 2005 10:41:42 -0400 (EDT) Original-To: Luc Teirlinck In-Reply-To: <200507190259.j6J2xmf16875@raven.dms.auburn.edu> (Luc Teirlinck's message of "Mon, 18 Jul 2005 21:59:48 -0500 (CDT)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41075 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41075 > The code I propose to remove does not take care of a problem which the > original code it replaced did address and which the current comment > still falsely claims it addresses: loading the file does currently > _not_ enable the minor mode if the standard value is non-nil and the > minor mode variable is unbound when the defcustom is evaluated. Please check the commit-history of this piece of code (e.g. with vc-annotate) to see that it used to do what you say it "should" do (i.e. also call the minor-mode function if the init-value is non-nil). The current code follows the following idea: Loading a file should change Emacs's state as little as possible, so the init-value of a minor mode should *describe* (not determine) the default state of the minor-mode (in the case where the minor-mode function is not executed). Stefan