From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Romain Francoise <romain@orebokech.com>
Newsgroups: gmane.emacs.devel
Subject: Re: dump-emacs not compatible with toolbar-mode
Date: Fri, 12 Aug 2005 19:51:57 +0200
Organization: orebokech dot com
Message-ID: <874q9v6o1u.fsf@pacem.orebokech.com>
References: <66b7e34b050807121011b801fc@mail.gmail.com>
	<E1E2HyL-0006Sv-5A@fencepost.gnu.org>
	<66b7e34b05080821192d448e82@mail.gmail.com>
	<E1E2bvw-0003pS-BY@fencepost.gnu.org>
	<66b7e34b050809201369b8c03c@mail.gmail.com>
	<E1E3E2W-0003io-0Y@fencepost.gnu.org>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1123869701 1187 80.91.229.2 (12 Aug 2005 18:01:41 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Fri, 12 Aug 2005 18:01:41 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 12 20:01:33 2005
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1E3dqU-0001vG-TP
	for ged-emacs-devel@m.gmane.org; Fri, 12 Aug 2005 20:01:31 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1E3doT-0001ix-Sg
	for ged-emacs-devel@m.gmane.org; Fri, 12 Aug 2005 13:59:25 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1E3do6-0001dt-Jz
	for emacs-devel@gnu.org; Fri, 12 Aug 2005 13:59:02 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1E3dnt-0001Vk-4f
	for emacs-devel@gnu.org; Fri, 12 Aug 2005 13:58:49 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1E3dns-0001U2-LC
	for emacs-devel@gnu.org; Fri, 12 Aug 2005 13:58:48 -0400
Original-Received: from [82.67.41.165] (helo=yeast.orebokech.com)
	by monty-python.gnu.org with esmtp (Exim 4.34)
	id 1E3dvU-00067N-LF; Fri, 12 Aug 2005 14:06:40 -0400
Original-Received: from pacem.orebokech.com (pacem.orebokech.com [192.168.1.3])
	by yeast.orebokech.com (Postfix) with ESMTP id 926D012F83;
	Fri, 12 Aug 2005 19:51:32 +0200 (CEST)
Original-Received: by pacem.orebokech.com (Postfix, from userid 1000)
	id 7787B5239A; Fri, 12 Aug 2005 19:51:57 +0200 (CEST)
Original-To: rms@gnu.org
Mail-Copies-To: nobody
X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM</2q'*t@MNa)R`k0h1KbUu
	"Ek%gXCQA(?k=Uf9}qgF_x#7/+Ql\R!NJ9[Z[ky\CTYI<H(kc][?[m%*rsf!OG11|f&H[VgX;
	),"!N JG6IziY\~""3M
In-Reply-To: <E1E3E2W-0003io-0Y@fencepost.gnu.org> (Richard M. Stallman's
	message of "Thu, 11 Aug 2005 10:28:12 -0400")
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:41964
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41964

"Richard M. Stallman" <rms@gnu.org> writes:

> I fixed this.  Thanks.

I'm assuming that your fix was this change:

2005-08-11  Richard M. Stallman  <rms@gnu.org>

	* image.c (syms_of_image): Init image_types here, and call
	define_image_type.
	(init_image): Not here.

It introduces a bug: now 'pbm and 'xbm aren't valid image types anymore:

ELISP> (image-type-available-p 'pbm)
nil
ELISP> (image-type-available-p 'xbm)
nil
ELISP>

Note that these two types are always supported in Emacs and you moved
their initialization...

This causes problems in Gnus because it relies on pbm being supported to
display X-Faces.

-- 
Romain Francoise <romain@orebokech.com> | I've become someone else's
it's a miracle -- http://orebokech.com/ | nightmare...