Re: display-mm-width return value off on Windows

[Ralf Angeli <angeli@caeruleus.net>]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

* Kim F. Storm (2006-08-24) writes:

> Ralf Angeli <angeli@caeruleus.net> writes:
>
>> Thanks for spotting this.  I think it should return nil.  More
>> specifically: If display-mm-* is called without an argument it should
>> return nil if the display the current frame is located on is not a
>> graphical one.  If display-mm-* is called with an argument it should
>> return nil if the target display is unavailable or not a graphical
>> one.  I can change the patch accordingly ...
>
> Pls. do.

You can find the updated patch attached.  The change log entry posted
before is still valid.

-- 
Ralf

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2078 bytes --]

Index: frame.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/frame.el,v
retrieving revision 1.238
diff -u -r1.238 frame.el
--- frame.el	20 Aug 2006 14:43:29 -0000	1.238
+++ frame.el	24 Aug 2006 16:13:09 -0000
@@ -1083,17 +1083,42 @@
      (t
       (frame-width (if (framep display) display (selected-frame)))))))
 
+(defcustom display-mm-dimensions-alist nil
+  "Alist for specifying screen dimensions in millimeters.
+Each element of the alist has the form (display . (width . height)),
+e.g. (\":0.0\" . (287 . 215)).
+
+The dimensions will be used for `display-mm-height' and
+`display-mm-width' if defined for the respective display.
+
+If there is an element with the special value t as display
+indicator, it will be used for all graphical displays not
+explicitely specified."
+  :version "22.1"
+  :type '(alist :key-type (choice (string :tag "Display name")
+				  (const :tag "Default" t))
+		:value-type (cons :tag "Dimensions"
+				  (integer :tag "Width")
+				  (integer :tag "Height")))
+  :group 'frames)
+
 (defun display-mm-height (&optional display)
   "Return the height of DISPLAY's screen in millimeters.
 If the information is unavailable, value is nil."
   (and (memq (framep-on-display display) '(x w32 mac))
-       (x-display-mm-height display)))
+       (or (cddr (assoc (or display (frame-parameter nil 'display))
+			display-mm-dimensions-alist))
+	   (cddr (assoc t display-mm-dimensions-alist))
+	   (x-display-mm-height display))))
 
 (defun display-mm-width (&optional display)
   "Return the width of DISPLAY's screen in millimeters.
 If the information is unavailable, value is nil."
   (and (memq (framep-on-display display) '(x w32 mac))
-       (x-display-mm-width display)))
+       (or (cadr (assoc (or display (frame-parameter nil 'display))
+			display-mm-dimensions-alist))
+	   (cadr (assoc t display-mm-dimensions-alist))
+	   (x-display-mm-width display))))
 
 (defun display-backing-store (&optional display)
   "Return the backing store capability of DISPLAY's screen.

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel