From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Magnus Henoch Newsgroups: gmane.emacs.devel Subject: Re: First call of url-generic-parse-url is broken Date: Thu, 16 Nov 2006 00:15:19 +0100 Message-ID: <874pt0nvy0.fsf@freemail.hu> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1163632567 12157 80.91.229.2 (15 Nov 2006 23:16:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 15 Nov 2006 23:16:07 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 16 00:16:04 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GkTz1-0006Gu-7M for ged-emacs-devel@m.gmane.org; Thu, 16 Nov 2006 00:15:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GkTz0-0002GC-Gi for ged-emacs-devel@m.gmane.org; Wed, 15 Nov 2006 18:15:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GkTym-0002FF-Cp for emacs-devel@gnu.org; Wed, 15 Nov 2006 18:15:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GkTyl-0002Eg-0b for emacs-devel@gnu.org; Wed, 15 Nov 2006 18:15:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GkTyk-0002EV-Lw for emacs-devel@gnu.org; Wed, 15 Nov 2006 18:15:38 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GkTyk-0000zw-E7 for emacs-devel@gnu.org; Wed, 15 Nov 2006 18:15:38 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GkTyY-0006Au-IQ for emacs-devel@gnu.org; Thu, 16 Nov 2006 00:15:26 +0100 Original-Received: from etthundrat.olf.sgsnet.se ([193.11.222.85]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Nov 2006 00:15:26 +0100 Original-Received: from mange by etthundrat.olf.sgsnet.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Nov 2006 00:15:26 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-To: emacs-devel@gnu.org Original-Lines: 18 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: etthundrat.olf.sgsnet.se Mail-Copies-To: never Jabber-Id: legoscia@jabber.cd.chalmers.se User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.90 (berkeley-unix) Cancel-Lock: sha1:fQ/jItx2sTVcdsqPbb15MlclfB4= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62364 Archived-At: Shun-ichi GOTO writes: > I chaised and found a bug. > url-generic-parse-url calls url-scheme-get-property in the > middle of the parsing to get port number for scheme. > But url-scheme-get-property invoke url-generic-parse-url again > to parse url value in url-proxy-services. > Because url-generic-parse-url uses fixed named buffer, > the buffer contents for first parse is broken by 2nd one. > > I suggest using with-temp-buffer for allocating working buffer > instead of get-buffer-create. > Or move use of url-schem-get-property to end of function > before (vector ...). I did the former. Thanks! Magnus