CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Denis Bueno]

With current CVS HEAD as of Fri Sep 14 12:37:35 EDT 2007 on my
computer, Darwin rrdhcp152-483.redrover.cornell.edu 8.10.1 Darwin
Kernel Version 8.10.1: Wed May 23 16:33:00 PDT 2007;
root:xnu-792.22.5~1/RELEASE_I386 i386 i386:

    emacs[37] > make maintainer-clean; ./configure --enable-carbon-app
    make: *** No rule to make target `maintainer-clean'.  Stop.
    checking build system type... i386-apple-darwin8.10.1
    checking host system type... i386-apple-darwin8.10.1
    checking for gcc... gcc
    checking for C compiler default output file name... a.out
    checking whether the C compiler works... yes
    checking whether we are cross compiling... no
    checking for suffix of executables...
    checking for suffix of object files... o
    checking whether we are using the GNU C compiler... yes
    checking whether gcc accepts -g... yes
    checking for gcc option to accept ISO C89... none needed
    checking how to run the C preprocessor... cc -E -no-cpp-precomp
    checking for grep that handles long lines and -e... /usr/bin/grep
    checking for egrep... /usr/bin/grep -E
    checking for AIX... no
    checking whether gcc understands -Wno-pointer-sign... yes
    checking whether ln -s works... yes
    checking how to run the C preprocessor... cc -E -no-cpp-precomp
    checking for a BSD-compatible install... /opt/local/bin/ginstall -c
    checking for ranlib... ranlib
    checking for install-info... /opt/local/bin/install-info
    checking for install-info... (cached) /opt/local/bin/install-info
    checking for install-info... (cached) /opt/local/bin/install-info
    checking for gzip... /opt/local/bin/gzip
    checking for makeinfo... /opt/local/bin/makeinfo
    configure: error: makeinfo >= 4.6 is required

But:

    emacs[38] > /opt/local/bin/makeinfo --version
    makeinfo (GNU texinfo) 4.11

    Copyright (C) 2007 Free Software Foundation, Inc.
    License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
    This is free software: you are free to change and redistribute it.
    There is NO WARRANTY, to the extent permitted by law.

Is this my problem or Emacs'?

                      Denis
--
"Editing is a rewording activity." -- Alan Perlis

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Glenn Morris]

"Denis Bueno" wrote:

>     checking for makeinfo... /opt/local/bin/makeinfo
>     configure: error: makeinfo >= 4.6 is required
>
> But:
>
>     emacs[38] > /opt/local/bin/makeinfo --version
>     makeinfo (GNU texinfo) 4.11

Sorry, my fault. Please try this patch to configure.in, followed by
running autoconf (or wait for me to check in a new configure if you
don't have a suitable autoconf).


*** configure.in	12 Sep 2007 07:03:30 -0000	1.474
--- configure.in	14 Sep 2007 17:20:46 -0000
***************
*** 1347,1353 ****
  dnl By this stage, configure has already checked for egrep and set EGREP, 
  dnl or exited with an error if no egrep was found.
  if test "$MAKEINFO" != "no" && \
!   test x"`$MAKEINFO --version 2> /dev/null | $EGREP 'texinfo[[^0-9]]*([[5-9]]|4\.[[6-9]])'`" = x; then
     MAKEINFO=no    
  fi
  
--- 1347,1353 ----
  dnl By this stage, configure has already checked for egrep and set EGREP, 
  dnl or exited with an error if no egrep was found.
  if test "$MAKEINFO" != "no" && \
!   test x"`$MAKEINFO --version 2> /dev/null | $EGREP 'texinfo[[^0-9]]*([[1-4]][[0-9]]+|[[5-9]]|4\.[[6-9]]|4\.[[1-5]][[0-9]]+)'`" = x; then
     MAKEINFO=no    
  fi

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Thien-Thi Nguyen]

here is an excerpt from texinfo 4.6 NEWS:

* Language:
  . new command @/ specifies an allowable breakpoint within a line.
  . new command @dofirstparagraphindent to control whether the first
    paragraph following a section heading is indented.  Default is to
    omit this indentation, unlike the output up to now.
  . new command @indent for explicitly indenting a paragraph.
  . makeinfo writes a new construct for @image in Info output, so that
    graphical Info browsers (such as Emacs Info under X) can display an
    actual image.  (Standalone Info ignores this, since it runs in a tty.)

i see that "grep @indent man/*.texi" yields nine hits.
so how about replacing the version check, like so:

+ echo @indent > conftest.texi
+ if test "$MAKEINFO" != "no" ; then
+    test $MAKEINFO conftest.texi >dev/null 2>&1 || MAKEINFO=no
+ fi
+ rm -f conftest.texi

such a construct is more in line w/ autoconf usage philosophy
(ie, don't check version; check desired features directly).

thi

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Eli Zaretskii]

> From: Thien-Thi Nguyen <ttn@gnuvola.org>
> Date: Fri, 14 Sep 2007 19:57:57 +0200
> Cc: Denis Bueno <dbueno@gmail.com>,
> 	"Emacs Dev \[emacs-devel\]" <emacs-devel@gnu.org>
> 
> i see that "grep @indent man/*.texi" yields nine hits.
> so how about replacing the version check, like so:
> 
> + echo @indent > conftest.texi
> + if test "$MAKEINFO" != "no" ; then
> +    test $MAKEINFO conftest.texi >dev/null 2>&1 || MAKEINFO=no
> + fi
> + rm -f conftest.texi
> 
> such a construct is more in line w/ autoconf usage philosophy
> (ie, don't check version; check desired features directly).

Not good enough: we also use the --enable-encoding command-line switch
to makeinfo.  It was also introduced in Texinfo 4.6.

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Thien-Thi Nguyen]

() Eli Zaretskii <eliz@gnu.org>
() Fri, 14 Sep 2007 22:00:35 +0300

   also use the --enable-encoding command-line switch

ok, here's a revised sketch:

+ echo @documentencoding ISO-8859-1 > conftest.texi
+ echo @indent >> conftest.texi
+ if test "$MAKEINFO" != "no" ; then
+    if $MAKEINFO --enable-encoding conftest.texi >dev/null 2>&1
+       then :
+       else MAKEINFO=no
+    fi
+ fi
+ rm -f conftest.texi conftest.info

btw, the cleanup is more thorough, too.  (basically, as we expand
our needs we expand the test in some convex-hull fashion.)

thi

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Denis Bueno]

On 9/14/07, Thien-Thi Nguyen <ttn@gnuvola.org> wrote:
> ok, here's a revised sketch:
>
> + echo @documentencoding ISO-8859-1 > conftest.texi
> + echo @indent >> conftest.texi
> + if test "$MAKEINFO" != "no" ; then
> +    if $MAKEINFO --enable-encoding conftest.texi >dev/null 2>&1
> +       then :
> +       else MAKEINFO=no
> +    fi
> + fi
> + rm -f conftest.texi conftest.info

For what it's worth, I did what you suggested [1] and it still doesn't
work.  But if I manually run `makeinfo --enable-encoding conftest.texi
&& echo hi`, "hi" is produced as output, so I'm confused.

Any other suggestions?

-- 
                              Denis

Index: configure.in
===================================================================
RCS file: /sources/emacs/emacs/configure.in,v
retrieving revision 1.474
diff -u -r1.474 configure.in
--- configure.in	12 Sep 2007 07:03:30 -0000	1.474
+++ configure.in	15 Sep 2007 13:30:30 -0000
@@ -1346,10 +1346,15 @@
 AC_PATH_PROG(MAKEINFO, makeinfo, no)
 dnl By this stage, configure has already checked for egrep and set EGREP,
 dnl or exited with an error if no egrep was found.
-if test "$MAKEINFO" != "no" && \
-  test x"`$MAKEINFO --version 2> /dev/null | $EGREP
'texinfo[[^0-9]]*([[5-9]]|4\.[[6-9]])'`" = x; then
-   MAKEINFO=no
+echo @documentencoding ISO-8859-1 > conftest.texi
+echo @indent >> conftest.texi
+if test "$MAKEINFO" != "no" ; then
+  if $MAKEINFO --enable-encoding conftest.texi >/dev/null 2>&1
+    then :
+    else MAKEINFO=no
+  fi
 fi
+rm -f conftest.texi conftest.info

 if test "$MAKEINFO" = "no"; then
   AC_MSG_ERROR( [makeinfo >= 4.6 is required] )

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Thien-Thi Nguyen]

() "Denis Bueno" <dbueno@gmail.com>
() Sat, 15 Sep 2007 09:57:49 -0400

   For what it's worth, I did what you suggested [1] and it
   still doesn't work.  But if I manually run `makeinfo
   --enable-encoding conftest.texi && echo hi`, "hi" is
   produced as output, so I'm confused.

   Any other suggestions?

i see that you changed configure.in but don't know what else
you did, to be able to say, "it still doesn't work".  here are
some suggestions:

 - w/ those changes, regenerate configure w/ GNU Autoconf 2.61
 - arrange for your system to have a known-good makeinfo
 - rerun configure (a)
 - arrange for your system to have a known-bad makeinfo
 - rerun configure (b)

since the subject of the test is "finding an appropriate
makeinfo", to test thoroughly, we want to see that the result
of (a) is that the makeinfo is found; and that the result of
(b) is that makeinfo is not found and furthermore configure
exits failurefully.

am i missing something?  did you mean something else as "it"?

thi

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Denis Bueno]

On 9/15/07, Thien-Thi Nguyen <ttn@gnuvola.org> wrote:
> () "Denis Bueno" <dbueno@gmail.com>
> () Sat, 15 Sep 2007 09:57:49 -0400
>
>    For what it's worth, I did what you suggested [1] and it
>    still doesn't work.  But if I manually run `makeinfo
>    --enable-encoding conftest.texi && echo hi`, "hi" is
>    produced as output, so I'm confused.
>
>    Any other suggestions?
>
> i see that you changed configure.in but don't know what else
> you did, to be able to say, "it still doesn't work".  here are
> some suggestions:

Sorry, I didn't realise there were so many options.  All I did was
re-run configure, which obviously won't work; but then, I'm not
familiar with this entire process.

I ran autoconf (2.61) and then configure and the test passed, for what
it's worth.

-- 
                              Denis

Re: CVS HEAD: configure: error: makeinfo >= 4.6 is required on Mac OS X

[Glenn Morris]

I corrected the existing implementation, but please feel free to
improve this test however you see fit.