unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] Changes to emacs/lisp/info.el,v
       [not found] <E1JXUgv-0007jP-DC@cvs.savannah.gnu.org>
@ 2008-03-07  5:49 ` Karl Fogel
  0 siblings, 0 replies; only message in thread
From: Karl Fogel @ 2008-03-07  5:49 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

Stefan Monnier <monnier@iro.umontreal.ca> writes:
> --- info.el	6 Mar 2008 21:43:06 -0000	1.515
> +++ info.el	7 Mar 2008 05:00:17 -0000	1.516
> @@ -4373,8 +4373,7 @@
>           (forward-str            (bookmark-get-front-context-string bmk))
>           (behind-str             (bookmark-get-rear-context-string bmk))
>           (place                  (bookmark-get-position bmk))
> -	 (info-node              (bookmark-get-info-node bmk))
> -	 (orig-file              file))
> +	 (info-node              (bookmark-get-info-node bmk)))
>      (if (setq file (bookmark-file-or-variation-thereof file))
>          (save-excursion
>            (save-window-excursion

`bookmark-get-info-node' is still being used here, but `bookmark.el' no
longer defines it as of revision 1.102.  Did you test? :-)

I was on the way to making what probably would have been the same
changes, when I updated and got your changes, so we're clearly on the
same page here!  See my commits immediately after yours.  I don't mean
to imply that I would not have written a bug, by the way -- it might not
have been this *particular* bug, but it would have been *some* bug.

-Karl




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-07  5:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1JXUgv-0007jP-DC@cvs.savannah.gnu.org>
2008-03-07  5:49 ` [Emacs-diffs] Changes to emacs/lisp/info.el,v Karl Fogel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).