From: Karl Fogel <kfogel@red-bean.com>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: [Emacs-diffs] Changes to emacs/lisp/info.el,v
Date: Fri, 07 Mar 2008 00:49:46 -0500 [thread overview]
Message-ID: <874pbjt75x.fsf@red-bean.com> (raw)
In-Reply-To: <E1JXUgv-0007jP-DC@cvs.savannah.gnu.org> (Stefan Monnier's message of "Fri, 07 Mar 2008 05:00:21 +0000")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> --- info.el 6 Mar 2008 21:43:06 -0000 1.515
> +++ info.el 7 Mar 2008 05:00:17 -0000 1.516
> @@ -4373,8 +4373,7 @@
> (forward-str (bookmark-get-front-context-string bmk))
> (behind-str (bookmark-get-rear-context-string bmk))
> (place (bookmark-get-position bmk))
> - (info-node (bookmark-get-info-node bmk))
> - (orig-file file))
> + (info-node (bookmark-get-info-node bmk)))
> (if (setq file (bookmark-file-or-variation-thereof file))
> (save-excursion
> (save-window-excursion
`bookmark-get-info-node' is still being used here, but `bookmark.el' no
longer defines it as of revision 1.102. Did you test? :-)
I was on the way to making what probably would have been the same
changes, when I updated and got your changes, so we're clearly on the
same page here! See my commits immediately after yours. I don't mean
to imply that I would not have written a bug, by the way -- it might not
have been this *particular* bug, but it would have been *some* bug.
-Karl
parent reply other threads:[~2008-03-07 5:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <E1JXUgv-0007jP-DC@cvs.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874pbjt75x.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).