unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Phil Hagelberg <phil@hagelb.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: vc-register complains if a file is already registered in a git repository
Date: Tue, 28 Oct 2008 15:24:21 -0700	[thread overview]
Message-ID: <874p2w73ze.fsf@hagelb.org> (raw)
In-Reply-To: <87ej207fc7.fsf@hagelb.org> (Phil Hagelberg's message of "Tue, 28 Oct 2008 11:19:04 -0700")

Phil Hagelberg <phil@hagelb.org> writes:

> Phil Hagelberg <phil@hagelb.org> writes:
>
>> I've added the vc-git-register-changes command to vc-git-extra-menu-map
>> and will start work on creating extra-keys functionality that works like
>> extra-menu.
>
> OK, here's the cumulative patch for both features.

Disregard that patch; it runs the append-extra-keys invocation at load
time, not when the vc-prefix-map is invoked.

It's really unclear due to the way prefix maps work how you can append
something to the map when it is invoked. For the menu maps it looks like
there are filter functions that are meant to do that, but it I can't
find any way to do this for prefix keymaps.

I suspect it would be much more straightforward if vc-register-changes
were simply a top-level vc command that most backends simply didn't
implement.

-Phil




      reply	other threads:[~2008-10-28 22:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 20:29 vc-register complains if a file is already registered in a git repository Phil Hagelberg
2008-10-21 21:43 ` Stefan Monnier
2008-10-21 22:23   ` Phil Hagelberg
2008-10-22  1:37     ` Stefan Monnier
2008-10-28 17:21       ` Phil Hagelberg
2008-10-28 18:19         ` Phil Hagelberg
2008-10-28 22:24           ` Phil Hagelberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874p2w73ze.fsf@hagelb.org \
    --to=phil@hagelb.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).