From: Chong Yidong <cyd@stupidchicken.com>
To: Yoni Rabkin <yoni@rabkins.net>
Cc: emacs-devel@gnu.org
Subject: Re: improving network utility calls in lisp/net/net-utils.el
Date: Sun, 02 Aug 2009 18:34:04 -0400 [thread overview]
Message-ID: <874ospsv4z.fsf@cyd.mit.edu> (raw)
In-Reply-To: <87my6im388.fsf@rabkins.net> (Yoni Rabkin's message of "Sun, 02 Aug 2009 22:21:11 +0300")
Yoni Rabkin <yoni@rabkins.net> writes:
> Does anyone have time to install this?
Terribly sorry for the delay, I haven't had time to review your patch
till just now.
With your change, the ifconfig, iwconfig, netstat, arp, and route
commands are no longer autoloaded. Could you fix this? (And
personally, I'd write out the function definitions manually instead of
using the net-utils-defutil macro, because the macro probably confuses
C-h f. It's not that much more work.)
Also, please make net-utils-font-lock-keywords a defvar, not a defconst
(make nslookup-font-lock-keywords a defvar too, while you're at it).
Once you make these changes, just send me the revised patch with a
ChangeLog entry, and I'll install it. Thanks for your patience.
next prev parent reply other threads:[~2009-08-02 22:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 13:18 improving network utility calls in lisp/net/net-utils.el Yoni Rabkin
2009-04-10 13:25 ` Stefan Monnier
2009-04-10 14:09 ` Yoni Rabkin
2009-04-10 16:40 ` David De La Harpe Golden
2009-04-10 17:55 ` Yoni Rabkin
2009-04-10 20:10 ` David De La Harpe Golden
2009-04-10 21:13 ` Yoni Rabkin
2009-04-11 0:42 ` Chad Brown
2009-04-10 22:13 ` Stefan Monnier
2009-04-11 8:47 ` Yoni Rabkin
2009-04-11 9:02 ` Eli Zaretskii
2009-04-11 9:17 ` Yoni Rabkin
2009-04-11 12:39 ` Stefan Monnier
2009-07-16 19:52 ` Yoni Rabkin
2009-07-26 8:02 ` Yoni Rabkin
2009-08-02 19:21 ` Yoni Rabkin
2009-08-02 22:34 ` Chong Yidong [this message]
2009-08-08 8:05 ` Yoni Rabkin
2009-08-08 18:27 ` Chong Yidong
2009-04-10 19:34 ` Dan Nicolaescu
2009-04-10 22:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ospsv4z.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=yoni@rabkins.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).