From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Add a keybinding to vc-dir Date: Tue, 01 Dec 2009 14:32:08 -0500 Message-ID: <874ooatrrb.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259695951 28827 80.91.229.12 (1 Dec 2009 19:32:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Dec 2009 19:32:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 01 20:32:24 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NFYSU-00036L-2E for ged-emacs-devel@m.gmane.org; Tue, 01 Dec 2009 20:32:22 +0100 Original-Received: from localhost ([127.0.0.1]:53232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFYST-0008TA-O1 for ged-emacs-devel@m.gmane.org; Tue, 01 Dec 2009 14:32:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFYSN-0008So-SC for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:32:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFYSI-0008QW-Cl for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:32:14 -0500 Original-Received: from [199.232.76.173] (port=56206 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFYSI-0008QR-7q for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:32:10 -0500 Original-Received: from pantheon-po38.its.yale.edu ([130.132.50.97]:39708) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NFYSH-0007EY-Si for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:32:10 -0500 Original-Received: from furry (dhcp128036014216.central.yale.edu [128.36.14.216]) (authenticated bits=0) by pantheon-po38.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id nB1JW8F0032623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 1 Dec 2009 14:32:09 -0500 Original-Received: by furry (Postfix, from userid 1000) id F0949C071; Tue, 1 Dec 2009 14:32:08 -0500 (EST) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118050 Archived-At: In the VC log, the "d" key calls log-view-diff. In VC-dir, the "=" key calls vc-diff (to match C-x v =). For mnemonic purposes, it might be good if log-view mode also binds "=" to log-view-diff, and VC-dir binds "d" to vc-diff. Any objections? The only obvious problem with doing this is if you (or others) plan to introduce more operations to vc-dir in the future, so that we need to conserve scarce keys. That doesn't seem like an issue to me, but thought I'd check in first.