From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Bell Date: Tue, 30 Mar 2010 19:16:51 +0300 Organization: JURTA Message-ID: <874ojxddnw.fsf@mail.jurta.org> References: <4BA0CDF9.40707@online.de> <76682E4761EA432EB929E5E199B0F92A@us.oracle.com> <87wrxb57e1.fsf@lola.goethe.zz> <20100317.200901.408057447.hanche@math.ntnu.no> <87sk7y2gh9.fsf@lola.goethe.zz> <87bpelic8g.fsf@mail.jurta.org> <878w9ox1x4.fsf@lola.goethe.zz> <87d3z074fs.fsf@stupidchicken.com> <87tyscysm2.fsf@mail.jurta.org> <87mxy23b3f.fsf@catnip.gol.com> <88262642C6164CD2872637E1309A66CB@us.oracle.com> <87iq8qikuu.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1269966257 31786 80.91.229.12 (30 Mar 2010 16:24:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 30 Mar 2010 16:24:17 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 30 18:24:13 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NweEf-00014n-2n for ged-emacs-devel@m.gmane.org; Tue, 30 Mar 2010 18:24:13 +0200 Original-Received: from localhost ([127.0.0.1]:43106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NweEe-0007jV-Cd for ged-emacs-devel@m.gmane.org; Tue, 30 Mar 2010 12:24:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NweBJ-0006Hk-2O for emacs-devel@gnu.org; Tue, 30 Mar 2010 12:20:45 -0400 Original-Received: from [140.186.70.92] (port=53730 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NweBF-0006Ek-PS for emacs-devel@gnu.org; Tue, 30 Mar 2010 12:20:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NweBE-0002Jz-21 for emacs-devel@gnu.org; Tue, 30 Mar 2010 12:20:41 -0400 Original-Received: from smtp-out1.starman.ee ([85.253.0.3]:48460 helo=mx1.starman.ee) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NweBD-0002Jr-Se for emacs-devel@gnu.org; Tue, 30 Mar 2010 12:20:40 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.68.10.cable.starman.ee [82.131.68.10]) by mx1.starman.ee (Postfix) with ESMTP id 1A5BC3F409F for ; Tue, 30 Mar 2010 19:20:33 +0300 (EEST) In-Reply-To: <87iq8qikuu.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 21 Mar 2010 01:59:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122924 Archived-At: > Currently in most cases a flashing screen is accompanied > with an error message. I think it's a bug when there is > no error message displayed. For instance, typing C-b or M-v > at the beginning of the buffer displays "Beginning of buffer", > but typing C-p doesn't display this error message. I think > it is a bug that should be fixed with this patch: Actually, `ding' with the error message deactivates the active region. Better to use `signal' that doesn't deactivate the region: === modified file 'lisp/simple.el' --- lisp/simple.el 2010-03-05 12:01:10 +0000 +++ lisp/simple.el 2010-03-20 23:57:09 +0000 @@ -4105,9 +4115,10 @@ (defun next-line (&optional arg try-vscr (insert (if use-hard-newlines hard-newline "\n"))) (line-move arg nil nil try-vscroll)) (if (called-interactively-p 'interactive) - (condition-case nil + (condition-case err (line-move arg nil nil try-vscroll) - ((beginning-of-buffer end-of-buffer) (ding))) + ((beginning-of-buffer end-of-buffer) + (signal (car err) nil))) (line-move arg nil nil try-vscroll))) nil) @@ -4135,9 +4146,10 @@ (defun previous-line (&optional arg try- (interactive "^p\np") (or arg (setq arg 1)) (if (called-interactively-p 'interactive) - (condition-case nil + (condition-case err (line-move (- arg) nil nil try-vscroll) - ((beginning-of-buffer end-of-buffer) (ding))) + ((beginning-of-buffer end-of-buffer) + (signal (car err) nil))) (line-move (- arg) nil nil try-vscroll)) nil) -- Juri Linkov http://www.jurta.org/emacs/