* bookmark from gnus article wrong modification
@ 2010-07-16 13:16 Thierry Volpiatto
2010-07-17 3:48 ` Karl Fogel
2010-07-20 1:22 ` Katsumi Yamaoka
0 siblings, 2 replies; 4+ messages in thread
From: Thierry Volpiatto @ 2010-07-16 13:16 UTC (permalink / raw)
To: emacs-devel
Hi,
the last modification for compatibility with older emacs in gnus-sum.el
is wrong.
You should use the value of pos what is set to point IN THE ARTICLE
BUFFER.
If you use just (point) it will record the value of point in the summary
buffer what is wrong and not what we want:
,----
| `(,subject
| ,@(condition-case nil
| (bookmark-make-record-default 'no-file 'no-context (point))
| (wrong-number-of-arguments
| (bookmark-make-record-default 'point-only)))
`----
See precedent patchs for example.
Also this change add tabs that also is wrong i think (you should
untabify).
This changes occur in:
,----
| changeset: 109420:8fa1cd12c77f
| user: Katsumi Yamaoka <yamaoka@jpl.org>
| date: Thu Jul 15 00:54:06 2010 +0000
| summary: Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
`----
--
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bookmark from gnus article wrong modification
2010-07-16 13:16 bookmark from gnus article wrong modification Thierry Volpiatto
@ 2010-07-17 3:48 ` Karl Fogel
2010-07-20 1:22 ` Katsumi Yamaoka
1 sibling, 0 replies; 4+ messages in thread
From: Karl Fogel @ 2010-07-17 3:48 UTC (permalink / raw)
To: Thierry Volpiatto; +Cc: emacs-devel
On Fri, Jul 16, 2010 at 9:16 AM, Thierry Volpiatto
<thierry.volpiatto@gmail.com> wrote:
> Hi,
> the last modification for compatibility with older emacs in gnus-sum.el
> is wrong.
> You should use the value of pos what is set to point IN THE ARTICLE
> BUFFER.
> If you use just (point) it will record the value of point in the summary
> buffer what is wrong and not what we want:
Thanks, Thierry. I'm on the road right now but will take care of this
once not traveling. On my list!
-Karl
> ,----
> | `(,subject
> | ,@(condition-case nil
> | (bookmark-make-record-default 'no-file 'no-context (point))
> | (wrong-number-of-arguments
> | (bookmark-make-record-default 'point-only)))
> `----
>
> See precedent patchs for example.
>
> Also this change add tabs that also is wrong i think (you should
> untabify).
>
> This changes occur in:
>
> ,----
> | changeset: 109420:8fa1cd12c77f
> | user: Katsumi Yamaoka <yamaoka@jpl.org>
> | date: Thu Jul 15 00:54:06 2010 +0000
> | summary: Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
> `----
>
>
> --
> Thierry Volpiatto
> Get my Gnupg key:
> gpg --keyserver pgp.mit.edu --recv-keys 59F29997
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bookmark from gnus article wrong modification
2010-07-16 13:16 bookmark from gnus article wrong modification Thierry Volpiatto
2010-07-17 3:48 ` Karl Fogel
@ 2010-07-20 1:22 ` Katsumi Yamaoka
2010-07-20 4:38 ` Thierry Volpiatto
1 sibling, 1 reply; 4+ messages in thread
From: Katsumi Yamaoka @ 2010-07-20 1:22 UTC (permalink / raw)
To: Thierry Volpiatto; +Cc: emacs-devel
Thierry Volpiatto wrote:
> the last modification for compatibility with older emacs in gnus-sum.el
> is wrong.
Oops, that's my fault. Thanks for pointing it out.
Fixed in both the Gnus trunk and the Emacs trunk.
Regards,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bookmark from gnus article wrong modification
2010-07-20 1:22 ` Katsumi Yamaoka
@ 2010-07-20 4:38 ` Thierry Volpiatto
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Volpiatto @ 2010-07-20 4:38 UTC (permalink / raw)
To: emacs-devel
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Thierry Volpiatto wrote:
>> the last modification for compatibility with older emacs in gnus-sum.el
>> is wrong.
>
> Oops, that's my fault. Thanks for pointing it out.
> Fixed in both the Gnus trunk and the Emacs trunk.
Thanks.;-)
--
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-20 4:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-16 13:16 bookmark from gnus article wrong modification Thierry Volpiatto
2010-07-17 3:48 ` Karl Fogel
2010-07-20 1:22 ` Katsumi Yamaoka
2010-07-20 4:38 ` Thierry Volpiatto
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).