From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Package menu not read-only Date: Sun, 24 Oct 2010 11:53:12 -0400 Message-ID: <874ocb4mfr.fsf@stupidchicken.com> References: <87eibfucm8.fsf@caeruleus.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1287935607 31729 80.91.229.12 (24 Oct 2010 15:53:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 24 Oct 2010 15:53:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ralf Angeli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 24 17:53:25 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PA2su-0007OK-Cb for ged-emacs-devel@m.gmane.org; Sun, 24 Oct 2010 17:53:25 +0200 Original-Received: from localhost ([127.0.0.1]:46777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PA2st-0005cl-SY for ged-emacs-devel@m.gmane.org; Sun, 24 Oct 2010 11:53:23 -0400 Original-Received: from [140.186.70.92] (port=33699 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PA2sp-0005ce-3v for emacs-devel@gnu.org; Sun, 24 Oct 2010 11:53:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PA2sn-0000IH-Pw for emacs-devel@gnu.org; Sun, 24 Oct 2010 11:53:19 -0400 Original-Received: from pantheon-po24.its.yale.edu ([130.132.50.118]:38012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PA2sn-0000I5-Nl for emacs-devel@gnu.org; Sun, 24 Oct 2010 11:53:17 -0400 Original-Received: from furball (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po24.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9OFrEtN032228 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 24 Oct 2010 11:53:14 -0400 Original-Received: by furball (Postfix, from userid 1000) id 309BB1607BF; Sun, 24 Oct 2010 11:53:13 -0400 (EDT) In-Reply-To: <87eibfucm8.fsf@caeruleus.net> (Ralf Angeli's message of "Sun, 24 Oct 2010 12:08:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132048 Archived-At: Ralf Angeli writes: > the buffer with the package menu (`M-x list-packages ') is not > read-only. The problem is due to `buffer-read-only' being set to nil in > `package--generate-package-list'. This seems to be unnecessary because > `inhibit-read-only' is temporarily set to t anyway. So I'd suggest the > following fix which I can apply if there are no objections. Thanks, committed. > I noticed the problem when typing in the buffer in order to jump > to the next "link". Apparently the package names are no links at all > and does not make much sense here. They are links, or rather buttons, and are clickable with the mouse. I've just changed package-menu-mode-map to make button-buffer-map its parent. This should let TAB work. > In order to make it more apparent that commands in the buffer work on > whole lines and the horizontal position of point is not really > relevant one could also highlight the whole line in which point is > located, similar to what RefTeX does in table of contents (`C-c =' in > a LaTeX file). I don't think it's a good idea for non-electric modes to highlight the whole line. For the case of the *Packages* menu, the text color helps to indicate each package's installation status, and it would be annoying to have this information masked hidden for the current line.