From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Tango color theme extension Date: Mon, 01 Nov 2010 11:22:01 -0400 Message-ID: <874oc1oyqu.fsf@stupidchicken.com> References: <28494_1288223216_ZZh0a0w~TGVRn.00_1288223213.2479.969.camel@steed.robot-madness> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288629459 2648 80.91.229.12 (1 Nov 2010 16:37:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 1 Nov 2010 16:37:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jan Moringen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 01 17:37:35 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PCxO1-0007mW-7N for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 17:37:34 +0100 Original-Received: from localhost ([127.0.0.1]:56106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCxNz-0005XP-UH for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 12:37:31 -0400 Original-Received: from [140.186.70.92] (port=38263 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCwDP-0008Gq-Hz for emacs-devel@gnu.org; Mon, 01 Nov 2010 11:22:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PCwCw-0004GG-Ru for emacs-devel@gnu.org; Mon, 01 Nov 2010 11:22:07 -0400 Original-Received: from pantheon-po43.its.yale.edu ([130.132.50.104]:43691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PCwCw-0004GA-P3 for emacs-devel@gnu.org; Mon, 01 Nov 2010 11:22:02 -0400 Original-Received: from furball (dhcp128036014027.central.yale.edu [128.36.14.27]) (authenticated bits=0) by pantheon-po43.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id oA1FM2YL019839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 1 Nov 2010 11:22:02 -0400 Original-Received: by furball (Postfix, from userid 1000) id 7265516108B; Mon, 1 Nov 2010 11:22:01 -0400 (EDT) In-Reply-To: <28494_1288223216_ZZh0a0w~TGVRn.00_1288223213.2479.969.camel@steed.robot-madness> (Jan Moringen's message of "Thu, 28 Oct 2010 01:46:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132239 Archived-At: Jan Moringen writes: > Hi, > > I noticed that a version of the Tango color theme has been added > recently. Since I had a custom version of the Tango color theme, I > merged the two versions. > > The introduced changes are: > > * Definition of the tango palette colors in a separate file > * Faces for Smerge, Ediff, flyspell, Semantic and outline > > Screenshots showing the Semantic and outline faces are attached. > > The attached patch does not integrate the new file into the build > system. Thanks. Some of these faces should probably inherit from font-lock faces. That would reduce the number of faces users, and theme writers, need to edit. When I get the time, I'll take a look into this, and merge the rest of your changes into tango-theme.el.