From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Reading char choices Date: Sat, 08 Jan 2011 14:35:13 -0500 Message-ID: <874o9jmbny.fsf@stupidchicken.com> References: <871v4ohesj.fsf@stupidchicken.com> <45079.130.55.118.19.1294420600.squirrel@webmail.lanl.gov> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1294515326 9062 80.91.229.12 (8 Jan 2011 19:35:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 8 Jan 2011 19:35:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: herring@lanl.gov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 08 20:35:22 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PbeZN-0001EN-Su for ged-emacs-devel@m.gmane.org; Sat, 08 Jan 2011 20:35:22 +0100 Original-Received: from localhost ([127.0.0.1]:43320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbeZN-0000tc-A3 for ged-emacs-devel@m.gmane.org; Sat, 08 Jan 2011 14:35:21 -0500 Original-Received: from [140.186.70.92] (port=59684 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbeZI-0000tL-6w for emacs-devel@gnu.org; Sat, 08 Jan 2011 14:35:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PbeZG-00030a-V0 for emacs-devel@gnu.org; Sat, 08 Jan 2011 14:35:15 -0500 Original-Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]:40548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PbeZG-00030V-P4 for emacs-devel@gnu.org; Sat, 08 Jan 2011 14:35:14 -0500 Original-Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p08JZDa5022548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 8 Jan 2011 14:35:14 -0500 Original-Received: by furball (Postfix, from userid 1000) id 90387161EAB; Sat, 8 Jan 2011 14:35:13 -0500 (EST) In-Reply-To: <45079.130.55.118.19.1294420600.squirrel@webmail.lanl.gov> (Davis Herring's message of "Fri, 7 Jan 2011 09:16:40 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:134375 Archived-At: "Davis Herring" writes: > Couldn't we pass the prompt to read-event? Also, how does this > inhibit quitting out of the whole function? > ... > If I'm missing something and we really do inhibit quitting, surely > this should be (unless inhibit-keyboard-quit ...). Fixed, thanks. Seems that dired-query, from which I factored out this code, was a bit buggy. >> ((setq done (memq char chars)))))) > > So if it's not valid, we just ignore it. Would we rather display a > message (as for `y-or-n-p'), at least optionally? That's fine if someone wants to implement it. Currently, we don't do this for the risky local variables prompt, nor for dired-query.