From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Cc: ding@gnus.org
Subject: Re: can Gnus simply use the Emacs bug tracker?
Date: Thu, 17 Mar 2011 14:12:13 -0500 [thread overview]
Message-ID: <874o7136k2.fsf@lifelogs.com> (raw)
In-Reply-To: m3y64dwspo.fsf@quimbies.gnus.org
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Thu, 17 Mar 2011 18:40:51 +0100 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
LMI> I think the Gnus variable snarfer and stuff should just be removed, and
LMI> gnus-bug should just be a shim over report-emacs-bugs. The variables
LMI> that are picked out can be somewhat sensitive, and not all that useful.
LMI> The standard report-emacs-bugs data is more useful, I think.
OK. Patch attached, although I didn't remove all the cruft related to
`gnus-bug' from gnus-msg.el or elsewhere. The patch is against the
Emacs trunk because it modifies `report-emacs-bug' a little bit.
On Thu, 17 Mar 2011 13:50:06 -0400 Glenn Morris <rgm@gnu.org> wrote:
GM> You can also specify a "Version: " pseudo-header, which can be useful.
GM> Though probably not very useful with a non-numeric version like "No Gnus
GM> v0.14".
I'm not sure either. Lars?
Ted
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-debbugs.patch --]
[-- Type: text/x-diff, Size: 3183 bytes --]
=== modified file 'lisp/gnus/gnus-msg.el'
--- lisp/gnus/gnus-msg.el 2011-02-23 13:35:35 +0000
+++ lisp/gnus/gnus-msg.el 2011-03-17 19:09:20 +0000
@@ -1429,42 +1429,15 @@
(gnus-inews-yank-articles (list (cdr gnus-article-current)))))))
(defvar nntp-server-type)
-(defun gnus-bug ()
+(defun gnus-bug (topic &optional recent-keys)
"Send a bug report to the Gnus maintainers."
- (interactive)
+ (interactive (reverse (list (recent-keys) (read-string "Bug Subject: "))))
(unless (gnus-alive-p)
(error "Gnus has been shut down"))
- (gnus-setup-message (if (message-mail-user-agent) 'message 'bug)
- (unless (message-mail-user-agent)
- (delete-other-windows)
- (when gnus-bug-create-help-buffer
- (switch-to-buffer "*Gnus Help Bug*")
- (erase-buffer)
- (insert gnus-bug-message)
- (goto-char (point-min)))
- (message-pop-to-buffer "*Gnus Bug*"))
- (let ((message-this-is-mail t))
- (message-setup `((To . ,gnus-maintainer) (Subject . ""))))
- (when gnus-bug-create-help-buffer
- (push `(gnus-bug-kill-buffer) message-send-actions))
- (goto-char (point-min))
- (re-search-forward (concat "^" (regexp-quote mail-header-separator) "$"))
- (forward-line 1)
- (insert (gnus-version) "\n"
- (emacs-version) "\n")
- (when (and (boundp 'nntp-server-type)
- (stringp nntp-server-type))
- (insert nntp-server-type))
- (insert "\n\n\n\n\n")
- (let (text)
- (with-current-buffer (gnus-get-buffer-create " *gnus environment info*")
- (erase-buffer)
- (gnus-debug)
- (setq text (buffer-string)))
- (insert "<#part type=application/emacs-lisp disposition=inline description=\"User settings\">\n" text "\n<#/part>"))
- (goto-char (point-min))
- (search-forward "Subject: " nil t)
- (message "")))
+ (let ((report-emacs-bug-address gnus-maintainer)
+ (report-emacs-bug-body-prepend
+ (format "Package: %s\n" gnus-bug-package)))
+ (report-emacs-bug topic recent-keys)))
(defun gnus-bug-kill-buffer ()
(when (get-buffer "*Gnus Help Bug*")
=== modified file 'lisp/gnus/gnus.el'
--- lisp/gnus/gnus.el 2011-03-06 02:43:19 +0000
+++ lisp/gnus/gnus.el 2011-03-17 19:08:27 +0000
@@ -2633,9 +2633,13 @@
(defvar gnus-have-read-active-file nil)
(defconst gnus-maintainer
- "bugs@gnus.org (The Gnus Bugfixing Girls + Boys)"
+ "submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)"
"The mail address of the Gnus maintainers.")
+(defconst gnus-bug-package
+ "gnus"
+ "The package to use in the bug submission.")
+
(defvar gnus-info-nodes
'((gnus-group-mode "(gnus)Group Buffer")
(gnus-summary-mode "(gnus)Summary Buffer")
=== modified file 'lisp/mail/emacsbug.el'
--- lisp/mail/emacsbug.el 2011-02-06 15:04:31 +0000
+++ lisp/mail/emacsbug.el 2011-03-17 18:37:08 +0000
@@ -171,6 +171,8 @@
(set (make-local-variable 'message-strip-special-text-properties) nil))
(rfc822-goto-eoh)
(forward-line 1)
+ (when (boundp 'report-emacs-bug-body-prepend)
+ (insert (symbol-value 'report-emacs-bug-body-prepend)))
(let ((signature (buffer-substring (point) (point-max))))
(delete-region (point) (point-max))
(insert signature)
next prev parent reply other threads:[~2011-03-17 19:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 16:38 can Gnus simply use the Emacs bug tracker? Ted Zlatanov
2011-03-15 17:40 ` Chong Yidong
2011-03-15 18:27 ` Ted Zlatanov
2011-03-15 19:32 ` Glenn Morris
2011-03-15 19:08 ` Stefan Monnier
2011-03-15 19:23 ` Glenn Morris
2011-03-15 19:41 ` Lars Magne Ingebrigtsen
2011-03-15 19:47 ` Ted Zlatanov
2011-03-15 23:27 ` Glenn Morris
2011-03-16 14:00 ` Ted Zlatanov
2011-03-16 15:41 ` Stefan Monnier
2011-03-16 15:58 ` Ted Zlatanov
2011-03-16 17:51 ` Glenn Morris
2011-03-16 17:55 ` Glenn Morris
2011-03-16 19:41 ` Stefan Monnier
2011-03-16 17:32 ` Lars Magne Ingebrigtsen
2011-03-16 18:44 ` Ted Zlatanov
2011-03-17 16:52 ` Lars Magne Ingebrigtsen
2011-03-17 17:27 ` Ted Zlatanov
2011-03-17 17:40 ` Lars Magne Ingebrigtsen
2011-03-17 17:50 ` Glenn Morris
2011-03-17 17:53 ` Glenn Morris
2011-03-18 8:33 ` Reiner Steib
2011-03-18 13:04 ` Ted Zlatanov
2011-03-29 18:53 ` Lars Magne Ingebrigtsen
2011-03-29 19:09 ` Ted Zlatanov
2011-06-28 15:31 ` Ted Zlatanov
2011-03-17 19:12 ` Ted Zlatanov [this message]
2011-06-28 15:33 ` Ted Zlatanov
2011-03-15 20:31 ` Chong Yidong
2011-03-15 20:45 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o7136k2.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).