From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: emacs 24 randomly hanging Date: Thu, 23 Feb 2012 16:05:18 +0800 Message-ID: <874nuix9dt.fsf@gnu.org> References: <878vjzz920.fsf@earth.home> <87sji4mpwn.fsf@this.that> <4F43CC35.60407@gmx.at> <8762f0qbam.fsf@this.that> <4F44A6A2.8040701@gmx.at> <87aa4byw66.fsf@gnu.org> <83k43eu91n.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1329984344 717 80.91.229.3 (23 Feb 2012 08:05:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Feb 2012 08:05:44 +0000 (UTC) Cc: rudalics@gmx.at, schwab@linux-m68k.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 23 09:05:43 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S0TgM-0001ji-FJ for ged-emacs-devel@m.gmane.org; Thu, 23 Feb 2012 09:05:42 +0100 Original-Received: from localhost ([::1]:51824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0TgL-0002co-Vq for ged-emacs-devel@m.gmane.org; Thu, 23 Feb 2012 03:05:41 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:45720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0TgF-0002cH-6L for emacs-devel@gnu.org; Thu, 23 Feb 2012 03:05:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0TgA-0001ww-6H for emacs-devel@gnu.org; Thu, 23 Feb 2012 03:05:35 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:40816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0TgA-0001ws-3e for emacs-devel@gnu.org; Thu, 23 Feb 2012 03:05:30 -0500 Original-Received: from [155.69.18.248] (port=33037 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S0Tg9-000390-76; Thu, 23 Feb 2012 03:05:29 -0500 In-Reply-To: <83k43eu91n.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Feb 2012 18:28:36 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148722 Archived-At: Eli Zaretskii writes: >> The problem is that x-create-frame calls x_set_menu_bar_lines, which >> calls window-configuration-change-hook. Because that hook is called in >> the middle of x-create-frame, the (half-initialized) frame isn't on >> Vframe_list yet. >> >> Patch welcome; I don't have time to work on this further right now. > > How about "don't do it"? I committed a change to inhibit window-configuration-change-hook there. There's another possible problem: x-create-frame sets the background-color parameter prior to the frame being put on Vframe_list. IIUC, this parameter needs to be set before we can consider the frame live, because the frame size calculation depends on the default face, which may in turn depend on the background mode. But setting the parameter causes a Lisp call to frame-set-background-mode, so we can in principle get in trouble if the user redefines or advises that function. But that's a sufficiently obscure corner case that we can leave it for post-24.1, I think.