unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rudalics@gmx.at, schwab@linux-m68k.org, emacs-devel@gnu.org
Subject: Re: emacs 24 randomly hanging
Date: Thu, 23 Feb 2012 16:05:18 +0800	[thread overview]
Message-ID: <874nuix9dt.fsf@gnu.org> (raw)
In-Reply-To: <83k43eu91n.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Feb 2012 18:28:36 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> The problem is that x-create-frame calls x_set_menu_bar_lines, which
>> calls window-configuration-change-hook.  Because that hook is called in
>> the middle of x-create-frame, the (half-initialized) frame isn't on
>> Vframe_list yet.
>> 
>> Patch welcome; I don't have time to work on this further right now.
>
> How about "don't do it"?

I committed a change to inhibit window-configuration-change-hook there.

There's another possible problem: x-create-frame sets the
background-color parameter prior to the frame being put on Vframe_list.
IIUC, this parameter needs to be set before we can consider the frame
live, because the frame size calculation depends on the default face,
which may in turn depend on the background mode.  But setting the
parameter causes a Lisp call to frame-set-background-mode, so we can in
principle get in trouble if the user redefines or advises that function.
But that's a sufficiently obscure corner case that we can leave it for
post-24.1, I think.



  reply	other threads:[~2012-02-23  8:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-19  5:28 emacs 24 randomly hanging Adam
2012-02-19  9:45 ` Adam
2012-02-19  9:54 ` Andreas Schwab
2012-02-20  7:23   ` Adam
2012-02-20 15:34 ` Dan Nicolaescu
2012-02-21 10:10   ` Adam
2012-02-21 10:43 ` Adam
2012-02-21 15:41   ` Dan Nicolaescu
2012-02-21 16:54     ` martin rudalics
2012-02-21 18:42       ` Adam
2012-02-22  8:26         ` martin rudalics
2012-02-22  9:01           ` Andreas Schwab
2012-02-22  9:41             ` martin rudalics
2012-02-22 14:49               ` Stefan Monnier
2012-02-24 18:43                 ` martin rudalics
2012-02-22 10:55             ` Chong Yidong
2012-02-22 16:28               ` Eli Zaretskii
2012-02-23  8:05                 ` Chong Yidong [this message]
2012-02-23 14:03                   ` Christopher Schmidt
2012-02-23 16:39                     ` Christopher Schmidt
2012-02-23 17:42                     ` Chong Yidong
2012-02-24 18:43                   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nuix9dt.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).