From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: filenotify.el Date: Tue, 23 Jul 2013 15:34:23 +0200 Message-ID: <874nblz9gg.fsf@gmx.de> References: <87d2ra9z4x.fsf@gmx.de> <7765700.YGZAUaTNB1@descartes> <87y595uthx.fsf@gmx.de> <51ED774C.4010309@lanl.gov> <87r4eqla94.fsf@gmx.de> <87a9ldzrul.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1374586486 30529 80.91.229.3 (23 Jul 2013 13:34:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Jul 2013 13:34:46 +0000 (UTC) Cc: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 23 15:34:46 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V1cji-0006ff-VX for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2013 15:34:43 +0200 Original-Received: from localhost ([::1]:50645 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1cji-0005me-85 for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2013 09:34:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1cjf-0005mU-5i for emacs-devel@gnu.org; Tue, 23 Jul 2013 09:34:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1cja-0001lS-Hg for emacs-devel@gnu.org; Tue, 23 Jul 2013 09:34:39 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:61030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1cja-0001lF-94 for emacs-devel@gnu.org; Tue, 23 Jul 2013 09:34:34 -0400 Original-Received: from detlef.gmx.de ([93.202.51.72]) by mail.gmx.com (mrgmx001) with ESMTPS (Nemesis) id 0Mb8MV-1UhcsO46Dj-00KfBv for ; Tue, 23 Jul 2013 15:34:33 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 23 Jul 2013 09:08:40 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:fyNMy7WKzIeZPFvXdnxTqwlm3PEWaLGT6/D8AdxyKSdY7xN+Jr0 NrKMtVmD0rGalo3syi4V3kcx1lzSTLCBPd5Vc9O+/Wn0lKa6aF0R7oOh0laxyEVE2kc2mE8 B8d9qaG8s6c/TsvdcukzmQEwWeXKwxoysy86STF8l1TjRJyxJtmiiC2gdLpUhH2z0HAXxHk T5OD6wXht/62PRoeipp4g== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162091 Archived-At: Stefan Monnier writes: >> It is more simple to implement for some Tramp file name handlers. For >> example, in the smb case I have mapped file-notify-supported-p to >> ignore. But of course I could implement it differently, let >> file-notify-add-watch return with a file-notify-error in that case. > > I think it's not an either/or situation: it's important for > file-notify-add-watch to return an error if it is not supported for that > file, regardless of the existence of file-notify-supported-p. I haven't meant to let behave file-notify-add-watch to return an error just because of this. Of course, it shall return file-notify-error anyway (marker to myself: we still must change it in w32notify.c). This shall be checked in corresponding ert tests (next marker to myself). Btw, file-notify-supported-p would ease to skip ert tests, if file notification is not available for the local or remote case. > Stefan Best regards, Michael.