From: Stephen Berman <stephen.berman@gmx.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Commit message header line
Date: Fri, 02 May 2014 18:06:35 +0200 [thread overview]
Message-ID: <874n185fn8.fsf@rosalinde.fritz.box> (raw)
In-Reply-To: <83oazg1c1a.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 May 2014 17:38:09 +0300")
On Fri, 02 May 2014 17:38:09 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
> Header lines such as these:
>
> Add a warning and a menu.
>
> Update, improve exposition, add cross references, fix typos.
>
> could be more useful if they included a reference to the feature you
> are fixing, in this case Todo Mode. Otherwise, the header lines are
> too generic.
Oh dear, sorry about that. Is it possible to fix that without reverting
and recommitting? I did this via VC, and thought the commit message
would include the string "calendar/todo-mode.el", since it is in the
ChangeLog entry copied into the commit log buffer, but I see it is not
in the log listing. But I notice that other log entries do have such a
string; were they explicitly added to the Subject: line in the commit
log buffer, or is that because the Subject: line was left blank so just
the first line of the ChangeLog entry was used? If so, is that
acceptable practice, or should the Subject: line always be filled in?
Steve Berman
next prev parent reply other threads:[~2014-05-02 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 14:38 Commit message header line Eli Zaretskii
2014-05-02 16:06 ` Stephen Berman [this message]
2014-05-02 16:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n185fn8.fsf@rosalinde.fritz.box \
--to=stephen.berman@gmx.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).