From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files Date: Wed, 21 Oct 2015 10:00:08 +0200 Message-ID: <874mhktzw7.fsf@gmail.com> References: <20151013135354.28594.43074@vcs.savannah.gnu.org> <87io69opbs.fsf@gmail.com> <83bnc083k3.fsf@gnu.org> <871tcvks7o.fsf@gmail.com> <83si5b54m9.fsf@gnu.org> <87wpunsz6w.fsf@gmail.com> <83mvvi6fu9.fsf@gnu.org> <87wpuhud8l.fsf@gmail.com> <87mvvdyx0i.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445414394 3459 80.91.229.3 (21 Oct 2015 07:59:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Oct 2015 07:59:54 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 09:59:45 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZooJF-0000zf-1S for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 09:59:45 +0200 Original-Received: from localhost ([::1]:49725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZooJE-0007PW-AR for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 03:59:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZooJB-0007PL-2D for emacs-devel@gnu.org; Wed, 21 Oct 2015 03:59:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZooJ7-0001k8-Ra for emacs-devel@gnu.org; Wed, 21 Oct 2015 03:59:40 -0400 Original-Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:35880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZooJ7-0001k0-Jg; Wed, 21 Oct 2015 03:59:37 -0400 Original-Received: by wicfx6 with SMTP id fx6so78785508wic.1; Wed, 21 Oct 2015 00:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=IAogIsukY9m1EnToV0ol3AGBCoUXm5JFZYJuQQC2r0c=; b=YgNNSYRuf2QlLJRQUZ4NS9v90GwAvknNJP/xq3KXPGeuTZBcWUsdQGMg7j8sV2+mH2 AwUr7yMlnf5McNvYA3bYo5EAEIQyhqAl5lmVEzr4erR82GiQa89qdhWnoTYmvuegt8CW lTAmIN4zo0QRHvWTf0cIXkgvJsi1upVW6bD7hFSwCO+89YYuBj0gglvXUBWJrro3payh pSIW07YY+CsLye2g1hCRDeE6dJkuUbqU7/zNEpimoG+3WxpeuaHcATMOj3RdAN5oS0Vf Y3EXHune1/8ix11TUvUWSni/cOgVsQlBkrF0zqf+6Ct0+H4hTPXPy6okk4o4A7rJcLa1 2Wmg== X-Received: by 10.194.110.170 with SMTP id ib10mr10021812wjb.69.1445414376908; Wed, 21 Oct 2015 00:59:36 -0700 (PDT) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by smtp.gmail.com with ESMTPSA id ki7sm8684334wjc.28.2015.10.21.00.59.35 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 21 Oct 2015 00:59:36 -0700 (PDT) In-Reply-To: <87mvvdyx0i.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 21 Oct 2015 01:51:11 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192268 Archived-At: Juri Linkov writes: >> I also want to add a new command to dired that compresses all marked >> files into a single named archive: the user gets prompted for a name >> (through `completing-read'+`read-file-name-internal') and the shell >> command is resolved from that name. I'd like for it to be bound by >> default, like "Z". Maybe like this: >> >> (define-key map "c" 'dired-compress) >> >> The proposed key isn't bound by default. Is that OK? > > Aren't upper-case Dired keys reserved for potentially dangerous commands > because upper-case keys are harder to press (require holding Shift-key). > I guess if your command will ask additional information from the minibuffer > then either lower-case "c" or "z" are fine because they won't run immediately. > "Z" would be good too if you could improve it in a backward-compatible way. I don't think it's possible to extend "Z", unless it's with a prefix arg or something, just because it already has a very different behavior for a group of marked files. Pressing something like "c" or "z" is much shorter than "C-u Z". And the logic is different anyway.