From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, bruce.connor.am@gmail.com, emacs-devel@gnu.org
Subject: Re: Please add comments to isearch.el
Date: Sun, 13 Dec 2015 01:27:45 +0200 [thread overview]
Message-ID: <874mfntfgq.fsf@mail.linkov.net> (raw)
In-Reply-To: <83d1uc6sdq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Dec 2015 09:25:05 +0200")
> Hey, I didn't suggest refactoring to begin with. I suggested to add
> commentary to explain how things work there. The example you give is
> just another confirmation of my observation that the code in
> isearch.el has long ago crossed the line of being unmaintainable, and
> I think we should fix that ASAP.
>
> Thanks.
I completely agree, and as a first step in this direction I propose
to fix the terminology used in isearch that should help to better
understand the code in isearch.el.
1. Rename ‘lax’ to ‘lax-boundary’ to distinguish between lax at the word/symbol
boundary and lax-whitespace to avoid confusion, so rename the
arg ‘lax’ to ‘lax-boundary’ in all regexp-producing functions,
isearch--lax-regexp-function-p to
isearch--lax-boundary-regexp-function-p, etc.
2. Try to find a better common naming scheme used for the
regexp-producing functions word-search-regexp, isearch-symbol-regexp,
character-fold-to-regexp.
3. Use well established terminology that shortens the prefixes
of character-related functions to just char- to use char-fold.
‘C-h f char TAB’ or ‘C-h v char TAB’ shows the standard
Emacs naming convention.
4. Use the upper-case standard name “Unicode” in the documentation.
next prev parent reply other threads:[~2015-12-12 23:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 16:34 Please add comments to isearch.el Eli Zaretskii
2015-12-11 8:13 ` Eli Zaretskii
2015-12-11 12:16 ` Alan Mackenzie
2015-12-11 12:39 ` Eli Zaretskii
2015-12-11 16:00 ` Artur Malabarba
2015-12-11 16:20 ` Eli Zaretskii
2015-12-11 16:54 ` Artur Malabarba
2015-12-11 16:56 ` Drew Adams
2015-12-11 18:33 ` Eli Zaretskii
2015-12-11 22:59 ` Juri Linkov
2015-12-11 23:24 ` Artur Malabarba
2015-12-11 23:55 ` Juri Linkov
2015-12-12 7:25 ` Eli Zaretskii
2015-12-12 23:27 ` Juri Linkov [this message]
2015-12-13 1:01 ` Artur Malabarba
2015-12-14 0:16 ` Juri Linkov
2015-12-14 1:19 ` Artur Malabarba
2015-12-14 23:51 ` Juri Linkov
2015-12-15 10:26 ` Artur Malabarba
2015-12-16 0:51 ` Juri Linkov
2015-12-16 9:06 ` Artur Malabarba
2015-12-17 0:55 ` Juri Linkov
2015-12-17 10:19 ` Artur Malabarba
2015-12-13 3:38 ` Eli Zaretskii
[not found] ` <<83d1uc6sdq.fsf@gnu.org>
2015-12-12 16:20 ` Drew Adams
2015-12-12 23:04 ` John Wiegley
[not found] <<83fuzoojcn.fsf@gnu.org>
2015-11-29 16:54 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mfntfgq.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=acm@muc.de \
--cc=bruce.connor.am@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).