From: Tino Calancha <tino.calancha@gmail.com>
To: Dima Kogan <Dmitriy.Kogan@jpl.nasa.gov>
Cc: tino.calancha@gmail.com, emacs-devel@gnu.org
Subject: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation
Date: Tue, 29 Nov 2016 21:07:33 +0900 [thread overview]
Message-ID: <874m2q1oca.fsf@gmail.com> (raw)
@@ -1959,8 +2064,8 @@ diff-refine-hunk
(interactive)
(require 'smerge-mode)
(save-excursion
- (diff-beginning-of-hunk t)
- (let* ((start (point))
+ (let* ((hunk-bounds (diff-bounds-of-hunk))
+ (start (goto-char (car hunk-bounds)))
(style (diff-hunk-style)) ;Skips the hunk header as well.
(beg (point))
(props-c '((diff-mode . fine) (face diff-refine-changed)))
@@ -1968,7 +2073,7 @@ diff-refine-hunk
(props-a '((diff-mode . fine) (face diff-refine-added)))
;; Be careful to go back to `start' so diff-end-of-hunk gets
;; to read the hunk header's line info.
- (end (progn (goto-char start) (diff-end-of-hunk) (point))))
+ (end (goto-char (cadr hunk-bounds))))
Hi Dima,
after the patch variable start is not used. You might want to rename
this var as _start, to avoid:
diff-mode.el:2086:48:Warning: Unused lexical variable ‘start’
next reply other threads:[~2016-11-29 12:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 12:07 Tino Calancha [this message]
2016-11-30 0:03 ` [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Noam Postavsky
2016-11-30 14:22 ` Dmitry Gutov
2016-11-30 14:31 ` Stefan Monnier
2016-11-30 14:34 ` Dmitry Gutov
2016-11-30 15:07 ` Stefan Monnier
2016-12-10 1:27 ` Dima Kogan
2016-12-10 10:14 ` Dmitry Gutov
2016-12-10 17:27 ` Dima Kogan
2016-12-11 11:07 ` Dmitry Gutov
2016-12-12 7:28 ` Dima Kogan
2016-12-16 1:05 ` Dmitry Gutov
2016-12-20 2:22 ` Tino Calancha
2016-12-20 7:31 ` Dima Kogan
2016-12-25 6:52 ` Dima Kogan
2016-12-25 9:48 ` Tino Calancha
2016-12-25 9:58 ` Tino Calancha
2016-12-25 14:10 ` Dmitry Gutov
2016-12-06 2:03 ` Mark Oteiza
2016-12-07 7:29 ` Dima Kogan
2017-01-06 2:58 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m2q1oca.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=Dmitriy.Kogan@jpl.nasa.gov \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).