unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master adfb6f1: Continue to fix bug#25607
Date: Wed, 15 Mar 2017 11:41:00 +0100	[thread overview]
Message-ID: <874lyult4z.fsf@detlef> (raw)
In-Reply-To: <jwv4lzvp515.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Wed, 15 Feb 2017 15:35:45 -0500")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>     * lisp/ido.el (ido-complete): Let-bind `non-essential' to nil.
>
> This looks wrong.  This in an interactive command executing an explicit
> request from the user, so it's definitely not non-essential.
>
> The compact on-the-fly display of the possible completions performed by
> IDO does qualify as `non-essential', but not ide-complete.

According to recent Tramp changes, binding `non-essential' in ido-mode
is not needed anymore. I've removed the bindings.

According to my (short) test, ido still behaves correctly. But I'm not
an ido user; other people might check this also.

>         Stefan

Best regards, Michael.



  parent reply	other threads:[~2017-03-15 10:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170215184246.30452.62655@vcs0.savannah.gnu.org>
     [not found] ` <20170215184247.DC51023357@vcs0.savannah.gnu.org>
2017-02-15 20:35   ` [Emacs-diffs] master adfb6f1: Continue to fix bug#25607 Stefan Monnier
2017-02-15 20:41     ` Dmitry Gutov
2017-02-15 21:45       ` Michael Albinus
2017-02-15 21:50       ` Stefan Monnier
2017-02-16 13:36         ` Michael Albinus
2017-02-16 15:01           ` Stefan Monnier
2017-02-15 21:41     ` Michael Albinus
2017-03-15 10:41     ` Michael Albinus [this message]
2017-03-15 14:41       ` Stefan Monnier
2017-03-15 14:48         ` Michael Albinus
2017-03-15 15:03           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lyult4z.fsf@detlef \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).