From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] json: Add support for encoding structs Date: Mon, 24 Apr 2017 09:25:56 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <874lxeq6mz.fsf@lifelogs.com> References: Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493040381 6378 195.159.176.226 (24 Apr 2017 13:26:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Apr 2017 13:26:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 24 15:26:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2e0K-0001Ra-2J for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2017 15:26:12 +0200 Original-Received: from localhost ([::1]:44205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2e0P-0000MU-Sy for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2017 09:26:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2e0H-0000MB-NU for emacs-devel@gnu.org; Mon, 24 Apr 2017 09:26:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2e0D-0003Xx-Fm for emacs-devel@gnu.org; Mon, 24 Apr 2017 09:26:09 -0400 Original-Received: from [195.159.176.226] (port=46900 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2e0D-0003VN-8g for emacs-devel@gnu.org; Mon, 24 Apr 2017 09:26:05 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d2e04-00014z-6q for emacs-devel@gnu.org; Mon, 24 Apr 2017 15:25:56 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 16 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:qL2Ghrpq3TP4K7b2lXFnAIkqnUU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214260 Archived-At: On Sun, 23 Apr 2017 15:46:35 +0530 Vibhav Pant wrote: VP> The following patch to json.el adds support for encoding record types VP> declared via cl-defstruct. It also allows the user to change the json VP> key for a struct field by using the `:json' keyword while declaring VP> a slot. Nice! I hope that goes in. Can you please write tests for it? Is it possible to also exclude fields with :json nil? I think that's very useful. Finally, it would be great to be able to declare the JSON type of the field. Ted