From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: Problem committing tests Date: Mon, 29 May 2017 10:08:43 +0200 Message-ID: <874lw4qe44.fsf@rosalinde> References: <87wp90ppu7.fsf@rosalinde> <871sr8xhn8.fsf@zigzag> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496045355 31012 195.159.176.226 (29 May 2017 08:09:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 May 2017 08:09:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 29 10:09:08 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFFjg-0007uN-Op for ged-emacs-devel@m.gmane.org; Mon, 29 May 2017 10:09:08 +0200 Original-Received: from localhost ([::1]:47385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFFjm-0002Cg-3K for ged-emacs-devel@m.gmane.org; Mon, 29 May 2017 04:09:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFFjP-00023O-II for emacs-devel@gnu.org; Mon, 29 May 2017 04:08:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFFjM-0006O8-By for emacs-devel@gnu.org; Mon, 29 May 2017 04:08:51 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:58471) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFFjM-0006LD-2M for emacs-devel@gnu.org; Mon, 29 May 2017 04:08:48 -0400 Original-Received: from rosalinde ([83.135.17.20]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LvV1X-1dwFbz3h5P-010enD for ; Mon, 29 May 2017 10:08:45 +0200 In-Reply-To: <871sr8xhn8.fsf@zigzag> (Thien-Thi Nguyen's message of "Mon, 29 May 2017 09:10:35 +0200") X-Provags-ID: V03:K0:9IEaKWzu+4cNGk7LqqxexCcCk9dGRSvSVc7AobnMfEodqlgqCtY rrv5Sc3aTs2Q3/25eGXy1z4oGGbNMYvEhZKTBsLUZhiMkr45zDAjTvaqhK3NtHiQCmTi/Gs kcGZNkMMNyuvAvhvtFzpuHcBVEGTNk2ONFUt1nFRFdPw1Um1OA5L/fklWu10G35nbytUsps wHi+AczBaQOvQQiBVNpdw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GUFV/gTM6IY=:pzCdrxtrUmAgX+evmRe5Pw Zq2mN/lcKn3jj3bxlk0LNiot1zrc5GsHY+f1rFdTYUvSizf3y9OY3prDdqgW4FD8Nt7O2fITk wt6SZIMqrKoziUwkOuq82nJGTPTK1sfTXJlAtoXsj4xGai2ypKKmnxz1yksd97RX42hFCp409 D3UUEYzDITdGuw+jmSdXF7Ym0+aumxqfyGYhsENSR6tD8F4Mt64u0bkX8urLg+hYRxbb40RTD qtbFECHLtWeJrCJGQjnyr8alDiWoGS+58J7KgCuTIk6S6Dmk2N0jKVfGX0GYq5c7IijqbEhTj UVOlW94KvQdO7UckSNf3wU9X7hw2q3jJ8G4nQogTYwvaxoS4cVFnYeEUKRL7Hjk2e66yUw1K5 e+JlrWRvJtaZU+KRVSwqaRqw2FV2spPj8bilZ8yVh3b43eMVwWthWn0SN3eUBAVmhxrI8tsd1 plJPoR7tW+AquxoZY/ODUlkURV3QbaebewoIW2WCbhqrjnA580kgRuCgtmigu6E0BTRlbFhqN VNFOhpdHbEnNERU+7DWDcbFLEJRcRja9mej+Gm7c4AmDknXenh+xm+vIskU+uZNCfCjOYNp4Q aLt2zcTiPvSUa21GcgtViKJaW+/ye79nJC1nnNqngzzCsE0IFm+0XvFGQFCBO2G/fKHxcN2JC n1yaUlVqgQPZ5y3lXtRxs9sXZCy+GeR0UCu29cf5dwx4e/zfPjcZjbWRTgDGKMtD+3Hg63IPx pL6+jBVz9GXhm+KBvTteciUFj/SuSsi9Leks9a7ZBDmkM9+LIhmTG/yKlfg4zC1YmkXbdcnc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215303 Archived-At: On Mon, 29 May 2017 09:10:35 +0200 Thien-Thi Nguyen wrote: > () Stephen Berman > () Mon, 29 May 2017 00:40:48 +0200 > > I wanted to include some tests with the fix for bug#27121 > that I just committed to master (d76c007); however, git > complained about trailing whitespace in two data files for > the tests. This whitespace is part of the file format used > by todo-mode.el, so I cannot delete it. I see that the > .gitattributes file in the repository lists several test > files for which whitespace warnings should be ignored; should > I add the todo-mode test data files to the list? Or is there > another or better way to tell git to ignore this whitespace > and commit the files? > > I think it would be cool to restructure the process so that the > eol ws-requiring data is generated at run-(test-)time from data > that has no eol ws. This is more work, but: Unfortunately, it is more than I currently have time for with my knowledge of and experience with git and the Emacs test environment. > - It is explicit. > - It avoids possible future lossage if the DVCS changes. > - It avoids possible future lossage via PEBKAC or ignorance. > (Just think, what if that fool ttn fubars this somehow!?) > - If the work should happen to be algorithmic (it is, what a > surprise! :-D), it could be generalized and re-used. > - If it is written well, it could be documented and exported. > > So, i urge you to put in the effort here, slap your name on it, > and bask in the glory of future Q/A chains terminating w/ a > time-saving link to righteous code (and relax{ed,ing} docs). > > IOW, it is good to cope, better to create, best to invest. I agree, but I'm afraid being good is the best I can hope for for now. So I'll wait a bit to see if any other manageable suggestions come up, otherwise I'll do the .gitattributes workaround. Steve Berman