From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do =?utf-8?Q?=E2=80=98s=2FUPattern=2FU-pattern=2Fg=E2=80=99=2C_=E2=80=98s=2F?= =?utf-8?Q?QPattern=2FQ-pattern=2Fg=E2=80=99?= Date: Sun, 13 May 2018 19:46:17 +0200 Message-ID: <874ljb78k6.fsf@gnuvola.org> References: <20180511165048.32157.10695@vcs0.savannah.gnu.org> <20180511165051.022C820545@vcs0.savannah.gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1526395428 2302 195.159.176.226 (15 May 2018 14:43:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 May 2018 14:43:48 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 15 16:43:44 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIbB2-0000Wt-H7 for ged-emacs-devel@m.gmane.org; Tue, 15 May 2018 16:43:44 +0200 Original-Received: from localhost ([::1]:41466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIbD9-0001Uk-J0 for ged-emacs-devel@m.gmane.org; Tue, 15 May 2018 10:45:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIb2Q-0001EX-1S for emacs-devel@gnu.org; Tue, 15 May 2018 10:34:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIb2M-0007pr-RD for emacs-devel@gnu.org; Tue, 15 May 2018 10:34:50 -0400 Original-Received: from mail.agora-net.com ([67.59.132.6]:43961) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fIb2M-0007om-Mb for emacs-devel@gnu.org; Tue, 15 May 2018 10:34:46 -0400 Original-Received: from ttn by mail.agora-net.com with local (Exim 4.82) (envelope-from ) id 1fIb2K-0000jR-Pi for emacs-devel@gnu.org; Tue, 15 May 2018 10:34:44 -0400 Original-Received: from ttn by zigzag.favinet with local (Exim 4.80) (envelope-from ) id 1fHv4l-0003fx-CU for emacs-devel@gnu.org; Sun, 13 May 2018 19:46:27 +0200 Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: (Stefan Monnier's message of "Sat, 12 May 2018 11:01:16 -0400") X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ttn@gnuvola.org X-SA-Exim-Scanned: No (on mail.agora-net.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 67.59.132.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225308 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable () Stefan Monnier () Sat, 12 May 2018 11:01:16 -0400 Hmm... I think this text should be changed to use the term "pattern" for "U(-)pattern". I've come around to this pov as well. See latest commits. WRT Q-pattern: My understanding is that `QPAT is an "extension" in deed (since it's implemented via =E2=80=98pcase-defmacro=E2=80=99), but perhaps "innate= " in spirit. I moved the "structural pattern" stuff to the (pcase-defmacro \` (qpat) ...) docstring and added a comment in =E2=80=98pcase--make-docstring=E2=80=99 (b= ut have not changed any code). I think if we can get `QPAT to be first in the extensions docs (in *Help*), this would satisfy both the maintainability best practice (keep documentation near its code) and the user experience best practice (good flow, ordering). What do people think? =2D-=20 Thien-Thi Nguyen ----------------------------------------------- (defun responsep (query) (pcase (context query) (`(technical ,ml) (correctp ml)) ...)) 748E A0E8 1CB8 A748 9BFA =2D-------------------------------------- 6CE4 6703 2224 4C80 7502 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlr4eewACgkQZwMiJEyAdQJbjwCeNgSJYDUtURJu+U1aTaAQfXPv M0wAn1IwspuBA00MQWvo5mjoGITTfdSb =SqR3 -----END PGP SIGNATURE----- --=-=-=--