Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’

[Thien-Thi Nguyen <ttn@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]


() Stefan Monnier <monnier@IRO.UMontreal.CA>
() Sat, 12 May 2018 11:01:16 -0400

   Hmm... I think this text should be changed to use the term
   "pattern" for "U(-)pattern".

I've come around to this pov as well.  See latest commits.

WRT Q-pattern:

My understanding is that `QPAT is an "extension" in deed (since
it's implemented via ‘pcase-defmacro’), but perhaps "innate" in
spirit.  I moved the "structural pattern" stuff to the

 (pcase-defmacro \` (qpat) ...)

docstring and added a comment in ‘pcase--make-docstring’ (but
have not changed any code).  I think if we can get `QPAT to be
first in the extensions docs (in *Help*), this would satisfy
both the maintainability best practice (keep documentation near
its code) and the user experience best practice (good flow,
ordering).

What do people think?

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)
   (pcase (context query)
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]