From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [elpa] scratch/prose-mode 9b83489: [prose-mode] Initial commit Date: Sat, 02 Jun 2018 21:56:20 -0700 Message-ID: <874lik79jf.fsf@ericabrahamsen.net> References: <20180603020324.23533.23581@vcs0.savannah.gnu.org> <20180603020325.282612053B@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528001846 12509 195.159.176.226 (3 Jun 2018 04:57:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2018 04:57:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 03 06:57:22 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPL4z-0003Av-Qz for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2018 06:57:21 +0200 Original-Received: from localhost ([::1]:33612 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPL77-0006ze-0p for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2018 00:59:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPL71-0006zY-0z for emacs-devel@gnu.org; Sun, 03 Jun 2018 00:59:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPL6x-0005vS-Ut for emacs-devel@gnu.org; Sun, 03 Jun 2018 00:59:27 -0400 Original-Received: from [195.159.176.226] (port=44961 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPL6x-0005v3-NB for emacs-devel@gnu.org; Sun, 03 Jun 2018 00:59:23 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fPL4n-0002zP-16 for emacs-devel@gnu.org; Sun, 03 Jun 2018 06:57:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 32 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:DOoZQWNZYAHh8HfZK0lA/iHk4XI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225949 Archived-At: Stefan Monnier writes: >> + (advice-add >> + 'kill-region >> + :after >> + #'prose-mode-add-yank-handler)) > > Hmm... could you use filter-buffer-substring-function to add the > yank-handler? Instead of the gross kill-ring hack? Yes, it look like this works much more cleanly: (add-function :filter-return filter-buffer-substring-function #'prose-mode-add-yank-handler) With a matching tweak to `prose-mode-add-yank-handler'. >> + (start-marker (set-marker (make-marker) (car bounds))) >> + (end-marker (set-marker (make-marker) (nth 1 bounds)))) > > I recommend `copy-marker`. Of course! Thanks. I'm going to dog-food this for a while (already seeing weird behavior), then do a proper [ELPA] announcement and see if anyone has any suggestions. Thanks again, Eric