unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Two problems with directory-local variables
Date: Thu, 20 Sep 2018 01:38:35 +0300	[thread overview]
Message-ID: <874leldw44.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvy3bzblj6.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Mon, 17 Sep 2018 22:15:07 -0400")

>>> On this note, while I don't use the commands myself, I've often wished
>>> that add-dir-local-variable would generate the dotted-pair syntax,
>>> because I've often seen confusion about the syntax of dir-locals arising
>>> from dotted vs non-dotted possibilities, and I feel strongly that the
>>> dotted syntax is the most readable for these files.
>
> Agreed.  We should probably have a `print-alist` kind of function for
> that purpose and then try and make use of it from add-dir-local-variable.
>
>> I don't know if something exists that could allow printing dotted syntax for
>>
>>   (pp-to-string '(eval message "hello"))
>>
>> In its implementation I see the references to print-escape-newlines
>> and print-quoted, but there is no print-dotted.
>
> I don't think we could add a print-dotted because as you say we don't
> want (eval . (message . ("hello" . nil))) and only the human coder can
> know which cons cell should be printed dotted and which shouldn't.

Examples in (info "(emacs) Directory Variables") recommend dotted syntax
for alists on the first level:

     ((nil . ((indent-tabs-mode . t)
              (fill-column . 80)))
      (c-mode . ((c-file-style . "BSD")
                 (subdirs . nil))))

as well as for the second level:

      (("src/imported"
        . ((nil . ((change-log-default-name
                    . "ChangeLog.local"))))))

Taking into account the original problematic case with `eval',
dotted alist should be also on the third level:

      (("src/imported"
        . ((nil . ((eval
                    . (message "hello")))))))

Given that, I don't see what would be a good choice for generalization:

1. Since requirements for this feature are too vague, it doesn't seem
   to fit well into low-level printing functions.

2. Reformatting the printed output in pp-buffer to add dots where necessary
   also doesn't look like an elegant solution.

3. Implementing print-alist poses a question how to define at which levels
   to print alists with dotted syntax.

4. Since only add-dir-local-variable knows the semantics of used data
   structures, the simplest way would be to implement printing of each level
   explicitly in add-dir-local-variable.



  reply	other threads:[~2018-09-19 22:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17  8:08 Two problems with directory-local variables Marcin Borkowski
2018-09-17  9:28 ` Phil Sainty
2018-09-17 15:45   ` Marcin Borkowski
2018-09-17 23:15     ` Juri Linkov
2018-09-18  0:04       ` Phil Sainty
2018-09-18  0:19         ` Juri Linkov
2018-09-18  2:15           ` Stefan Monnier
2018-09-19 22:38             ` Juri Linkov [this message]
2018-09-20  1:42               ` Drew Adams
2018-09-20 20:59                 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874leldw44.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).