From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: disk-usage Date: Tue, 19 Feb 2019 21:21:41 +0100 Message-ID: <874l8z7cmi.fsf@gmx.de> References: <87imxgmacr.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="240207"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers To: Pierre Neidhardt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 19 21:22:27 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gwBuM-0010Lv-Rl for ged-emacs-devel@m.gmane.org; Tue, 19 Feb 2019 21:22:26 +0100 Original-Received: from localhost ([127.0.0.1]:54584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwBuL-0006Pj-Mr for ged-emacs-devel@m.gmane.org; Tue, 19 Feb 2019 15:22:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwBtl-0006PH-Bx for emacs-devel@gnu.org; Tue, 19 Feb 2019 15:21:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwBtk-0001qe-4W for emacs-devel@gnu.org; Tue, 19 Feb 2019 15:21:49 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:58457) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwBtj-0001pp-RX for emacs-devel@gnu.org; Tue, 19 Feb 2019 15:21:48 -0500 Original-Received: from detlef.gmx.de ([212.86.47.115]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUUWN-1gWW0q33xb-00RJm4; Tue, 19 Feb 2019 21:21:43 +0100 In-Reply-To: <87imxgmacr.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Tue, 19 Feb 2019 09:49:24 +0100") X-Provags-ID: V03:K1:6Trp8b+1vXk83g/z5BhAygVBo6O6VUBGtSo6qsT3BYeEHCC4RtK 6UkazaEdHQdiClmCbvPoUhYy4ULblsixJ/seWPLgaySlTDE1Q7O39tAYlEwldT9DcN9s6H/ Ud6EqlaZbY9dhEPz9sc4ga5cVfYHffSHTYR8UZ7HbLA5nrGqeLkv2g64K9eWrCpLPMFekBN s7wuG6Xx+IgOj2FYwKdkw== X-UI-Out-Filterresults: notjunk:1;V03:K0:zto46YnBB4Q=:EGL8dcpQRGXe7rd9/93Ymt 6fVNz3IN8exnQf7pEgxV9id7w6rLVTliaoYN8BdTEj/RmIdwqVdvoiRPppVauz7IpOCjl/wEh /WsZ6lhFPbhsEB7g3DQ7AyiYu1vx2TQ5FGxGCIyVHnWJCGOtMtqYMUu4N9OltpjdQ0VWHYGBU 6DmgR9v96zshhIPm7ToUdvPdAXBTVbB8WojuK1C2iaKiFn71SmGyLvTSTVUUhL4UTyre17wMY j2hAOtSDsJrw9C2lvCIg0O/UShhU03lycyUggZzWMCLxapScbpxGTyLqs3TvnsJWjAyX8cKil MoStrHzMnErv3cPytBVHTemx8E6fFXqXErhOzM7RshNosw5uOsMqnOorTn3DXxf1lE2QYupxr cfT34lzLc0qh92xIEzt8GUKoxsFk2p3558lhz5L9XeTUTQ6/as2xIhKcti9EiH/ZS08OXDGh2 OdjkFywKIAWAXVZ3FOwOkgcrb+Sc8rAgNUUl5niV0nEM+RMhV2AYBmID2k/MLaI4WEIp0g5sA hLVpW3DYZN3uh9kbgPv8UxvhU8da3xbDWspxVty4mX/bNZDYxA1WUqoQ3PYZaIEf+cqVRnYQU 6KapKIE448CT4De2++5exyL186z7qVuKqkB7AZQ8ArnJ/emb9/h7DzrGTwCBbDeD4OCgeSzfz Rg4bGB01veC2cLJh93ogp7qGU3LIc6kN0zEQEV79Er8sjHfJJ6MQQ8a2/0wi4qrQHzoGk00RI bvowmB4O8FklmpbVqpRce/O2NRQ+yqbZcpymjYUOtPGMqSxlAV/Ito+gHus9QHNtvJzwIXtO X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233468 Archived-At: Pierre Neidhardt writes: > Hi! Hi Pierre, > I'm happy to announce disk-usage.el > (https://gitlab.com/ambrevar/emacs-disk-usage), a disk analyzer for Emacs! Thanks! Is there a reason you apply `call-process' instead of `process-file'? With the latter, you could scan also directories on remote machines. > Feedback is more than welcome! One suggestion: you know for sure key bindings. Other people won't. Maybe you could add a menue for your *disk-usage<...>* buffers? Furthermore, could you pls adapt Emacs coding rules? Respecting 80 columns per line max, providing a docstring for all functions comes to mind. This would help to read your code. > Cheers! Best regards, Michael.