From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) Newsgroups: gmane.emacs.devel Subject: Re: Add support for base64url variant Date: Tue, 11 Jun 2019 20:36:52 +0200 Message-ID: <874l4wt1dn.fsf@killashandra.ballybran.fr> References: <87pnobiglo.fsf@killashandra.ballybran.fr> <83r28p57jp.fsf@gnu.org> <87zhnd55eq.fsf@killashandra.ballybran.fr> <83mujd54qv.fsf@gnu.org> <87lfyr4p49.fsf@killashandra.ballybran.fr> <834l50pk1p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223558"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (gnu/linux) Cc: Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 11 20:38:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1halfc-000vxr-2H for ged-emacs-devel@m.gmane.org; Tue, 11 Jun 2019 20:38:56 +0200 Original-Received: from localhost ([::1]:38144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1halfb-0008Fi-2M for ged-emacs-devel@m.gmane.org; Tue, 11 Jun 2019 14:38:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50653) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haldo-0008En-Ap for emacs-devel@gnu.org; Tue, 11 Jun 2019 14:37:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haldn-0006PZ-DP for emacs-devel@gnu.org; Tue, 11 Jun 2019 14:37:04 -0400 Original-Received: from smtp4-g21.free.fr ([212.27.42.4]:6004) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1haldk-0006LG-KM; Tue, 11 Jun 2019 14:37:00 -0400 Original-Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e0a:1e2:f8b0:9cc3:35bf:aa81:ccf7]) by smtp4-g21.free.fr (Postfix) with ESMTPS id 51CE219F5C3; Tue, 11 Jun 2019 20:36:53 +0200 (CEST) In-Reply-To: <834l50pk1p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Jun 2019 11:18:10 +0300") X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 212.27.42.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237439 Archived-At: Eli Zaretskii writes: >> From: pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) >> Cc: emacs-devel@gnu.org >> Date: Mon, 27 May 2019 22:30:14 +0200 >>=20 >> You'll find two patches attached. > > Thanks, I liked the second one better, so I pushed it. Thank you. Honestly I didn't expect it was accepted without further modifications. > > Please note that the doc strings and the manual text included a few > typos, and also used the passive tense too much. See the follow-up > changes I pushed after your changeset. In the future, I suggest to > use the Emacs spell-checking capabilities to spell-check the text in > the manual and also the comments/strings in the C/Lisp sources. This was the part I was the less confident (and for good reasons). Thanks again to have (completely) rewritten it. I'll try to be more rigorous in the future with the doc, NEWS, etc.. I'll also thanks Paul Eggert for his optimizations of the new functions in commit 5abaea334cf4c0e004fca2b8b272e091eb5b5444. Pierre. P.S. Would it be any interest if I try to add others bases encoding as defined in RFC 4648 ? I think, first, to BASE32 and maybe on BASE16 later.