From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nicolas Goaziou Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: Reconciling org-mode idiosyncrasies with Emacs core Date: Mon, 04 May 2020 16:50:42 +0200 Message-ID: <874ksv4uv1.fsf@nicolasgoaziou.fr> References: <20200426172206.GC18629@ACM> <87y2qhnc9a.fsf@gmail.com> <20200427102311.GA4976@ACM> <87mu6xtano.fsf@gmail.com> <87k120ohsq.fsf@mail.linkov.net> <87blnbir01.fsf@nicolasgoaziou.fr> <87o8rbmbfa.fsf@mail.linkov.net> <87k11yftqo.fsf@nicolasgoaziou.fr> <87pnbqo74t.fsf_-_@gmail.com> <87ees6fp8r.fsf@nicolasgoaziou.fr> <87y2q89dx7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123388"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Emacs developers , Org Mode list , Juri Linkov To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 04 16:54:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVcTv-000VvN-GW for ged-emacs-devel@m.gmane-mx.org; Mon, 04 May 2020 16:54:07 +0200 Original-Received: from localhost ([::1]:38476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVcTu-00079p-Da for ged-emacs-devel@m.gmane-mx.org; Mon, 04 May 2020 10:54:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVcQm-0001DZ-6T; Mon, 04 May 2020 10:50:52 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:47899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVcQk-00044N-GJ; Mon, 04 May 2020 10:50:51 -0400 X-Originating-IP: 185.131.40.67 Original-Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9F91620002; Mon, 4 May 2020 14:50:43 +0000 (UTC) Mail-Followup-To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec , Juri Linkov , Org Mode list , Emacs developers In-Reply-To: <87y2q89dx7.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Mon, 04 May 2020 12:45:24 +0200") Received-SPF: pass client-ip=217.70.183.200; envelope-from=mail@nicolasgoaziou.fr; helo=relay7-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 10:50:44 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248829 gmane.emacs.orgmode:128845 Archived-At: Hello, K=C3=A9vin Le Gouguec writes: > I took a stab at making RET obey electric-indent-mode in org-mode. Thank you! > I've got something working; I'd like to ask for a review before moving > on to Changelog and ORG-NEWS entries (and tackling C-j=E2=80=A6 and maybe > writing a few unit tests?). Tests for `org-return' (named "test-org/return") are in the "test-org.el" file in the "testing/lisp" directory. We only need to test if electric-indent-mode has an effect, but only in regular cases. > Here's the patch, with some additional comments below: It looks good. > - INTERACTIVE is what makes 'newline' run 'post-self-insert-hook' (thus > triggering indentation through electric-indent-mode), OK. I thought it was necessary to call `electric-newline-and-maybe-indent'. > - ARG wasn't strictly necessary, but it seemed harmless to add it, and > it allows inserting multiple newlines, thus removing one more "Org > idiosyncrasy". Good idea. > I felt that introducing org--newline made the code clearer, but I can > understand if it seems too trivial to keep. No, that's fine. > I took the liberty of using > this function in the "list item" case too, otherwise there's no way to > indent the trailing text. I'm not sure what you mean. It would be a regression if you didn't use the function there, too, wouldn't it? > (Out of curiosity, could it be argued that this is solving a "bug" in > org-mode and, as such, could be committed to Emacs core first, then > backported to the org-mode repository? I don't feel strongly either > way, I wouldn't want to make things more complicated for Org > maintainers.) I cannot speak for the Emacs side, but it should land in Org 9.4, not Org 9.3.6. It is a very visible change, one that every Org user is going to face. This requires a new ORG-NEWS entry. Those only appear in new minor+ releases. Therefore, if you apply it in Emacs 27.1, the change will be announced nowhere. > Now for C-j, in order to minimize breakage (for anyone calling > org-return-indent from Lisp code) and simplify disabling the new > behaviour (by simply turning off electric-indent-mode in Org), should we > bind C-j to a new function? E.g.: > > (defun org-return-and-maybe-indent () > (interactive) > (org-return (not electric-indent-mode))) I think so. Then we can mark `org-return-indent' as obsolete and suggest to call `org-return' instead. Regards, --=20 Nicolas Goaziou