From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: master f51f963: Fix some side-effecting uses of make-text-button Date: Fri, 05 Jun 2020 09:27:13 +0000 Message-ID: <874krp3lse.fsf@gmail.com> References: <20200604223056.17078.81265@vcs0.savannah.gnu.org> <20200604223058.1850020A26@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="52169"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org, Stefan Monnier , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 05 11:28:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jh8e2-000DRb-SV for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 11:28:10 +0200 Original-Received: from localhost ([::1]:34300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jh8e1-0005V8-TD for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 05:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jh8dF-0003u2-OY for emacs-devel@gnu.org; Fri, 05 Jun 2020 05:27:22 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:54976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jh8dE-0003Fs-Ob for emacs-devel@gnu.org; Fri, 05 Jun 2020 05:27:21 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id g10so7773485wmh.4 for ; Fri, 05 Jun 2020 02:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OAi3Liqf6biLEE0fPZjNRGQ39v/1/qL+asYG5mXdTEg=; b=r/q/1b3M2DriE9qGN8/8aBuuC90gGG4w0FGRGw33pcpnE+d8DDPaOrq1B77aIJG6Gt i+S5zCtKxf1lpXWIn21nVuivKFEEGhvgttAN5ZSck2FuvOXiwjnoswZk6hRd5PHPMCwr olqrbDwTeSiuyKjALxn8OAAsJVrXDveQ24r+tNc6He+4zmqZQr1O0B7oWwc86t7AuS6x 8FULY9lT+PYujJD74nu/OKnz4v8ZuH5VpmOiy+FCqKD0TqSqVr+F5C7IHB7RqHhIoZ7C 1ODNJixafA/tfKZStl0NnZ3h4jg8xbJ6Oobdr5ngzhF+0uB90eKFlnotA1cY8leRhTd6 8NuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OAi3Liqf6biLEE0fPZjNRGQ39v/1/qL+asYG5mXdTEg=; b=jJS2OImEiqaqnyJrHoxV31HmRRlfLCAUlBtfB+W64+/ql0fnTLw9j4Q+YoaUZwff0H jmzghg5pT9DTT9PHxtSIGKEP3EejxZrRlF3kKyPZ29hmm/KK1pJK9OcSeZEHtmFgAmwI wmmM2w4Mq59efqVUgIHultGdIzmAOjW76SED5c2Alle4GAQXIqXoARBKsN6LxJLgRaQz +ONuBddPl2jG/4GLpd0b1JSC+MIEi2EYSrau1dfCgcEHwe5TxuDVYsHSocui10X/uO7r lAckLc9scJBnqlJurnii7WD6lEB3lh9pGszk5aXalOJ7VjUZPaSCfzIdsEg8v5q1OxTy 2fbw== X-Gm-Message-State: AOAM533UoxxSq33xt/SQ2TuenNU9EHq6TwvqTdxtLP5mCWHSEu8WeU5q SDVIF/tnjiH7KEhM3TEUQHAQv9qiEpc= X-Google-Smtp-Source: ABdhPJxYtjSMFfyxmK644Fm14+EPEfdYZzNd95RkF/MiVsZ7/N4D8AIrc5f+HbAd1JZ71mxAq2MN2w== X-Received: by 2002:a1c:2b46:: with SMTP id r67mr1889138wmr.160.1591349239036; Fri, 05 Jun 2020 02:27:19 -0700 (PDT) Original-Received: from chametz ([31.220.2.131]) by smtp.gmail.com with ESMTPSA id n7sm11420100wrx.82.2020.06.05.02.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 02:27:18 -0700 (PDT) In-Reply-To: (Paul Eggert's message of "Thu, 4 Jun 2020 17:58:01 -0700") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=pipcet@gmail.com; helo=mail-wm1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251885 Archived-At: Paul Eggert writes: > diff --git a/lisp/button.el b/lisp/button.el > index 3a6a6de774..76b0e9102f 100644 > --- a/lisp/button.el > +++ b/lisp/button.el > @@ -341,7 +341,7 @@ make-text-button > as the argument for the `action' callback function instead of the > default argument, which is the button itself. > > -BEG can also be a string, in which case it is made into a button. > +BEG can also be a string, in which case a copy of it is made into a button. "and returned", I think. People will need to use the return value now.