From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master b8062be 3/5: Remove some compat code from eudc-bob.el Date: Wed, 12 Aug 2020 19:56:33 +0200 Message-ID: <874kp7lpda.fsf@gnus.org> References: <20200812175454.4839.92908@vcs0.savannah.gnu.org> <20200812175456.C5D122172E@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1161"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 12 19:57:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5v0Y-0000DR-A9 for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 19:57:50 +0200 Original-Received: from localhost ([::1]:47468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5v0X-0004b6-Cu for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 13:57:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5uzS-00049l-3L for emacs-devel@gnu.org; Wed, 12 Aug 2020 13:56:42 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:37530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5uzQ-0005lc-Hj for emacs-devel@gnu.org; Wed, 12 Aug 2020 13:56:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rgxwz5VYWDHj8US4VXu7kLYzeCCLXe9XiSjiOsO1Xdc=; b=rrMwH7MQH+yqFp1K1EeVARBIf7 Mab7+PQspf/oDoO8+zDpA5ku8uoq/RRXkrL75yW+0XVGKmWO1lU5EefBzVXnT3Gw6zC2hlpY8+164 YXu3K2WfAUJ578AV/c8pPAxhyuB5L7WZ+Gf/CZka0cIuIoHwIZsj+h13S9XvdmLN5FYs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5uzK-0003jn-PU for emacs-devel@gnu.org; Wed, 12 Aug 2020 19:56:38 +0200 In-Reply-To: <20200812175456.C5D122172E@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Wed, 12 Aug 2020 13:54:56 -0400 (EDT)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253705 Archived-At: larsi@gnus.org (Lars Ingebrigtsen) writes: > (save-excursion > - (if (fboundp 'set-buffer-file-coding-system) > - (set-buffer-file-coding-system 'binary)) > + (set-buffer-file-coding-system 'binary) > (set-buffer buffer) This seems like "obviously wrong code" (setting the coding system and then doing `set-buffer'), but I don't use eudc, so ... perhaps it really wants to set the coding system in the original buffer? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no