From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sat, 12 Sep 2020 18:47:49 +0200 Message-ID: <874ko3gcwa.fsf@gmx.de> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> <87a6xv456t.fsf@gnus.org> <837dszdyqv.fsf@gnu.org> <877dsz2o03.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12360"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , mardani29@yahoo.es, stefan@marxist.se, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 18:51:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH8k8-00034H-0C for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 18:51:16 +0200 Original-Received: from localhost ([::1]:57056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH8k6-0007FM-Do for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 12:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH8gv-0005UQ-D3 for emacs-devel@gnu.org; Sat, 12 Sep 2020 12:47:57 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:39697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH8gs-0002MA-HQ; Sat, 12 Sep 2020 12:47:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599929270; bh=yWn0ptvM3Gh3VZ8sLqNvCaaXXMdCOF6uk8fgpKa0Xys=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=a+Lvj3QGjeI4/UeCMCQktrc0DyK6CwRbQa2SlCQxNua5clzkWjQ+8e8eS6q0m44ke aEWu1sWCERP14wcEjPVJ+bOA9JOwAjvWNkrwV19jZHpy8+QvFBInYIds3fI12ery+T wFKSTxP//bdpX+YHDSh2qsOHznTuNkJ/dg5M/ti4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.41.134]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTRR0-1k4vt42JLQ-00Thx5; Sat, 12 Sep 2020 18:47:50 +0200 In-Reply-To: <877dsz2o03.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Sep 2020 14:11:40 +0200") X-Provags-ID: V03:K1:hcSNp9SPsiB61tRhF1HoKnL/yKLdFgxNBG4isTS3o5oS4Hl7AX7 DI5phrvv9ZxxWGKKdTlxHJLrHFQZTz8C6LSSa2hGPF0DcVYUY3/cgGuM2Ks04nTCqxRo/Rc o5r0VG+cL/Czj33qiJKvOj64STWEnDS6nH6WcpBqNEQKcUvJhS/6hsF8oozckaztMepGDkW c0rdP/2+wgrEgi8qEq1Uw== X-UI-Out-Filterresults: notjunk:1;V03:K0:xAavDNfVz3U=:hTO7dLf0ajerUE9vnJYpHR 3e07GnC5hOUtoBTi9z8ES/wKb8GUTkSOjRdiv5HFljI/OOLB0TwINrr5Ybxg7gAQxFMfATckV LmuWNdcQzppWrxgo2tARRkac4tlGNuMwY1Hv3+kxhBF4kUSY8oJ/bwrGr7XtZx2TboZyIOBED bu5npjGy/WED0s3P1872p/iOhELQv8jPZcSjcQqrvzcMF9rNrfakVe6fHKi/pqff80ObS4SCH gegQOGYdUO7/BoIMuCxCq0qwH2SnNMcY/IVwUC5yWgbbHlzH9NsgZpWEAEt0UHfiQGK4KCXWl 2ZH1mD0JXoRjw+S1EBxGMWfNJNAKHGhRlfYT/iMLtsVuV/N/3gx+2LGGalRfuShqjY0w4feu4 vHWK+8A6JCuAJNEdpqq/x6gUx5jUEdoz8PnEUJqHpFE+zFPX/HAHXtM8Ej0oF1FjTbTxxtVF7 rIE2wpUg9Nr9RyQCbq7n345X8mBtx7Xx4D5apZ+nb77mTnJhDZsW5xHSA9wtCwU6jcgMAnw4y CLn+83sTc6RCye88hnJRaBvDkBpsj8+iaDTmfO3AnS+rMl334F6EdxsCe46sCG7LTG7i5JJur kfZLqKiK5UjWIhQKLrEVsXknZAhc9hr5Ri7lEUTT/EGW7wrrUPWxGVQddgjaj1KIUm5hmsm1a j1b9wa66GqHni69SPAoumRgd3S/tbKb7YdTQJttnUX5OtAWTfT5ewKfBkybgdJdoqgfFDB3EX BHRjaH5FRuPS/8S/wVpfGIclNedC616hu4yJ1fIk/PY7pNGg/CbKl1SxaqZUGJGPGE/EQb3Y Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/12 12:47:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255387 Archived-At: Lars Ingebrigtsen writes: Hi Lars, > We've already made this decision with all the tests previously marked as > expensive, so there's nothing new here. We are formalising what counts > as a "too slow" test for the default "make check" case. When I have marked tests as expensive, I've always checked that the test isn't needed for the basic feature, and whether the test runs long. I believe an expensive test must be evaluated for both criteria. Best regards, Michael.