From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 6458e16: New mode outline-cycle-minor-mode with Orgmode-like TAB cycling on headings Date: Sun, 07 Mar 2021 20:54:43 +0200 Organization: LINKOV.NET Message-ID: <874khmhk0c.fsf@mail.linkov.net> References: <20210303191236.24697.93201@vcs0.savannah.gnu.org> <20210303191237.2B2D720E1B@vcs0.savannah.gnu.org> <87zgzkug5d.fsf@mail.linkov.net> <87a6rj44k6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1977"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Gabriel do Nascimento Ribeiro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 07 19:56:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIyZm-0000Q7-5H for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 19:56:26 +0100 Original-Received: from localhost ([::1]:47454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIyZl-0000AN-7b for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 13:56:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIyZ8-0007di-Q8 for emacs-devel@gnu.org; Sun, 07 Mar 2021 13:55:46 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:56385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIyZ6-00076S-W8 for emacs-devel@gnu.org; Sun, 07 Mar 2021 13:55:46 -0500 X-Originating-IP: 91.129.108.46 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 0F1031C0005; Sun, 7 Mar 2021 18:55:41 +0000 (UTC) In-Reply-To: <87a6rj44k6.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Mar 2021 11:05:29 +0200") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266143 Archived-At: >> This is a great feature, thank you! I could replace all my custom elisp >> code that handles outline cycle/highlight on my init.el with the new >> minor-modes, and everything has been working fine so far. >> >> I think that having only the variables is fine, I can't see any special >> need for the minor-modes. >> >>> 4. (advice-add 'xref--insert-xrefs :after >>> (lambda (&rest _args) >>> (setq-local outline-regexp "/") >>> (outline-cycle-minor-mode +1))) >>> using file names as headings where S-TAB could provide >>> an overview of all found files >> >> The use of outline-minor-mode + cycle on xref buffers is one of my main >> use cases. However, having to setup the outline-regexp and to add a >> defadvice seems a dirty hack. Should Emacs provide better defaults for >> xref and other modes (like Gnus) for an easier integration with >> outline-minor-mode ? > > Gnus has own outline-like commands like 'T H' that hides all threads. > But in xref it should be easy to set the outline-regexp by default, > and to add a hook to call when the xref output buffer is ready. Now this should be added in bug#46992. >> As another suggestion, would be nice to add more keybidings, for >> example, to navigate between headers. > > Maybe bind more org-like bindings in outline-mode-cycle-map, > e.g. ‘C-c C-n’ like ‘org-next-visible-heading’ > and ‘C-c C-p’ like ‘org-previous-visible-heading’. Actually it's easy to customize such keys, e.g.: (let ((map outline-mode-cycle-map) (cmds '(("C-c C-n" outline-next-visible-heading) ("C-c C-p" outline-previous-visible-heading)))) (dolist (command cmds) (define-key map (kbd (nth 0 command)) `(menu-item "" ,(nth 1 command) ;; Only takes effect if point is on a heading. :filter ,(lambda (cmd) (when (outline-on-heading-p) cmd))))))