From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Some minor suggestions to Tab Bar Date: Mon, 15 Mar 2021 11:24:50 +0200 Organization: LINKOV.NET Message-ID: <874khcsqct.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39052"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Gabriel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 15 10:50:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLjrg-0009zn-Ic for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Mar 2021 10:50:20 +0100 Original-Received: from localhost ([::1]:42092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLjrf-0005mq-J8 for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Mar 2021 05:50:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLjqs-0004yG-1g for emacs-devel@gnu.org; Mon, 15 Mar 2021 05:49:30 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:51153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLjqp-0002z7-IV for emacs-devel@gnu.org; Mon, 15 Mar 2021 05:49:29 -0400 X-Originating-IP: 91.129.108.46 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7BF2C4000F; Mon, 15 Mar 2021 09:49:24 +0000 (UTC) In-Reply-To: (Gabriel's message of "Sun, 14 Mar 2021 19:51:23 -0300") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266478 Archived-At: > Tab Bar is awesome and the recently added features to work with tab > groups made it even better. I know it's still a working in progress, but > I would like to suggest some minor improvements: Thanks for suggestions. The current implementation is not yet finished. It will take a few days to polish and push remaining patches. But you are welcome to try it out now and to make suggestions for improvements. > 1. Add an initial input for the 'completing-read' of > 'tab-bar-change-tab-group', so when we type 'C-x t G' to set/unset the > group name, the minibuffer contents is filled with the current group > value. A possible downside is that pressing TAB may not show the > Completions list, in case the current value does not match any item of > the completion list provided. Prefilling the initial contents of the minibuffer is deprecated. This is what the documentation says about it: The argument INITIAL is mostly deprecated; we recommend using a non-‘nil’ value only in conjunction with specifying a cons cell for HISTORY. For default input, use DEFAULT instead. > 2. Add new faces for group tabs. The idea is to differentiate these 2 > cases: > 2.1. Tabs from the current group X tabs from other groups > 2.2. Regular tabs X collapsed group tabs Your suggestions 3, 4, 5 are currently already under construction, but for the suggestion 2 of adding new faces your help is needed to design a set of new faces. This your list could be used as a base where new faces could be created: > * [1], [2] and [8] are tabs that do not belong to any group (ungrouped) > * [3] is a collapsed group tab of a group named "group1", where tab > [4] belongs to the same group and is hidden > * [5] and [7] are tabs that belongs to the current group (same group) > * [6] is the current active tab